Skip to content

refactor(caddy): detect named routes with Helper.IsNamedRoute() #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 1 commit into from
Nov 7, 2026
+1 −6
Merged

refactor(caddy): detect named routes with Helper.IsNamedRoute() #2815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions caddy/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,18 +331,13 @@ const namedRouteServerIndexBase = 1 << 20

func (f *FrankenPHPModule) assignServerIndex(h httpcaddyfile.Helper) {
counter, ok := h.State["php_server_count"].(int)
if !ok && inNamedRoute(h) {
if !ok && h.IsNamedRoute() {
counter = namedRouteServerIndexBase
}
f.ServerIndex = counter + 1
h.State["php_server_count"] = counter + 1
}

// inNamedRoute relies on Caddy setting the named_routes option only once all named routes are adapted
func inNamedRoute(h httpcaddyfile.Helper) bool {
return h.Option("named_routes") == nil
}

// parseCaddyfile unmarshals tokens from h into a new Middleware.
func parseCaddyfile(h httpcaddyfile.Helper) (caddyhttp.MiddlewareHandler, error) {
m := &FrankenPHPModule{}
Expand Down
Loading