Repository navigation
Conversation
jorgsowa
commented
Oct 30, 2026
|
|
||
| for (uint32_t i = 0; i < hook_list->children; i++) { | ||
| zend_ast_decl *hook = (zend_ast_decl *)hook_list->child[i]; | ||
| zend_ast_export_visibility(str, hook->flags, ZEND_MODIFIER_TARGET_PROPERTY); |
Contributor
Author
There was a problem hiding this comment.
Property hooks cannot declare visibility in source
jorgsowa
force-pushed
the
fix-hook-by-ref-ast-export
branch
from
November 5, 2026 10:48
e28acc8 to
2331052
Compare
ZEND_ACC_RETURN_REFERENCE shares a bit with ZEND_ACC_PRIVATE_SET, so &get was exported as private(set) get.
jorgsowa
force-pushed
the
fix-hook-by-ref-ast-export
branch
from
November 11, 2026 15:49
2331052 to
6827e8d
Compare
iliaal
approved these changes
Nov 12, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
LGTM. Hooks also lose their parameter list and attributes on export (set(int $v) => $v prints as set => $v), could be folded in here or done separately.
Contributor
Author
|
Thanks. I will take care in next PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZEND_ACC_RETURN_REFERENCEshares a bit withZEND_ACC_PRIVATE_SET, so &get was exported as private(set) get.