Repository navigation
Fix case-insensitive handling of .php extensions - #2046
Open
sy-records wants to merge 1 commit into
Open
sy-records wants to merge 1 commit into
sy-records wants to merge 1 commit into
Conversation
sy-records
requested review from
derickr,
saundefined and
sgolemon
as code owners
October 28, 2026 03:16
Contributor
|
📊 Regression report for commit d909a48 is at https://web-php-regression-report-pr-2046.preview.thephp.foundation |
Contributor
|
🚀 Preview for commit d909a48 is available at https://web-php-pr-2046.preview.thephp.foundation |
sy-records
marked this pull request as draft
October 28, 2026 03:30
sy-records
marked this pull request as ready for review
October 28, 2026 03:37
derickr
reviewed
Nov 12, 2026
|
|
||
| // Fix for case-insensitive .php extension, e.g. /supported-versions.PHP, /downloads.PHP | ||
| $originalURI = $URI; | ||
| $URI = preg_replace('/\.php\z/i', '.php', $URI); |
Member
There was a problem hiding this comment.
Why use \z over $ here? (I had not seen \z before, so had to look it up!)
Member
Author
There was a problem hiding this comment.
Using $ is enough here; I've modified it.
| if (!in_array($phpPageName, ['mirror-info', 'error', 'mod'], true) && | ||
| file_exists(ProjectGlobals::getPublicRoot() . "/$phpPage") && | ||
| (!$hasPhpExtension || $URI !== $originalURI)) { | ||
| mirror_redirect("/$phpPage"); |
Member
There was a problem hiding this comment.
What situation does this address? The commit message only talks about the case-insensitivity.
Member
Author
There was a problem hiding this comment.
This redirects the incorrect address to the correct one. e.g. php.net/downloads.PHP to php.net/downloads.php
sy-records
force-pushed
the
fix/error
branch
from
November 13, 2026 06:35
d909a48 to
569b12d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2045