Skip to content

Fix case-insensitive handling of .php extensions #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sy-records wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix case-insensitive handling of .php extensions #2046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions public/error.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,19 +181,21 @@
mirror_redirect("https://github.com/php/php-src/issues/" . $matches[1]);
}

// php.net/supported-versions.PHP -> supported-versions.php
if ($URI == 'supported-versions.PHP') {
mirror_redirect("https://www.php.net/supported-versions.php");
}

// Fix for case-insensitive .php extension, e.g. /supported-versions.PHP, /downloads.PHP
$originalURI = $URI;
$URI = preg_replace('/\.php$/i', '.php', $URI);

// ============================================================================
// Redirect if the entered URI was a PHP page name (except some pages,
// which we display in the mirror's language or the explicitly specified
// language [see below])
if (!in_array($URI, ['mirror-info', 'error', 'mod'], true) &&
file_exists(ProjectGlobals::getPublicRoot() . "/$URI.php")) {
mirror_redirect("/$URI.php");
$hasPhpExtension = str_ends_with($URI, '.php');
$phpPage = $hasPhpExtension ? $URI : "$URI.php";
$phpPageName = $hasPhpExtension ? substr($URI, 0, -4) : $URI;
if (!in_array($phpPageName, ['mirror-info', 'error', 'mod'], true) &&
file_exists(ProjectGlobals::getPublicRoot() . "/$phpPage") &&
(!$hasPhpExtension || $URI !== $originalURI)) {
mirror_redirect("/$phpPage");

@derickr derickr Nov 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What situation does this address? The commit message only talks about the case-insensitivity.

@sy-records sy-records Nov 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This redirects the incorrect address to the correct one. e.g. php.net/downloads.PHP to php.net/downloads.php

}

// Work with lowercased URI from now
Expand Down
Loading