Repository navigation
Conversation
Sets require.php to >=8.3.36 and composer/installers to ^1.0 || ^2.0, removes phpbb/phpbb from require (it belongs only in extra.soft-require, where Composer ignores it), and sets soft-require to phpBB 3.3.19 with the upper bound ext.php enforces. Made with phpbb-release-tools normalize-composer.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kb_declared_support_test checked that composer.json listed phpbb/phpbb under require with the same bounds as soft-require. With phpBB now only in extra.soft-require, it checks that require has no phpbb/phpbb and that soft-require still states ext.php's minimum and the <4.1.0@dev cap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Pushed 60f8ed4: Claude ran that test file on phpBB 3.3.x and master, the way this repo's CI runs PHPUnit: 17 tests pass on both. The full suite, with its MySQL and PostgreSQL tests, runs in CI on this push. Investigated and written by Claude on behalf of William Jacoby (bonelifer). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
composer.jsonto the phpbbmodders baseline for phpBB 3.3.19 and PHP 8.3.36. Only these keys change; key order, indentation and line endings stay as they are.phpbb/phpbb(>=3.3.19 <4.1.0) fromrequire. phpBB belongs only inextra.soft-require, which Composer ignores; underrequire, Composer would try to resolve phpBB itself.composer/installers:~2.0→^1.0 || ^2.0Made with
normalize-composer.py(phpbbmodders/phpbb-release-tools#50).Testing (by Claude):
composer validate: no errors, and no warnings the old file didn't have.smoke_test.pyon a phpBB 3.3.19 board: the same result as the default branch. The one existing problem: itsset_orderroute returns 403 without a form token. This change doesn't touch it.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code