Skip to content

chore: composer.json baseline for phpBB 3.3.19 and PHP 8.3.36 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bonelifer wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: composer.json baseline for phpBB 3.3.19 and PHP 8.3.36 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d16725
chore: composer.json baseline for phpBB 3.3.19 and PHP 8.3.36
bonelifer Nov 5, 2026
60f8ed4
Test that phpBB is only a soft requirement
bonelifer Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
],
"require": {
"php": ">=8.3.36",
"phpbb/phpbb": ">=3.3.19 <4.1.0",
"composer/installers": "~2.0"
"composer/installers": "^1.0 || ^2.0"
},
"extra": {
"display-name": "Knowledge Base",
Expand Down
10 changes: 5 additions & 5 deletions tests/kb_declared_support_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,16 @@ public function test_the_ci_matrix_starts_at_the_declared_minimum()
$this->assertContains($primary[1], $versions);
}

public function test_the_phpbb_requirement_and_soft_requirement_agree_and_state_the_same_minimum_as_ext_php()
public function test_phpbb_is_only_a_soft_requirement_stating_the_same_minimum_as_ext_php()
{
$composer = $this->composer();
$hard = $composer['require']['phpbb/phpbb'];
$soft = $composer['extra']['soft-require']['phpbb/phpbb'];

$this->assertSame('>=' . ext::MIN_PHPBB_VERSION, explode(' ', $hard)[0]);
// phpBB belongs only in extra.soft-require, which Composer ignores; under require, Composer would
// try to resolve phpBB itself.
$this->assertArrayNotHasKey('phpbb/phpbb', $composer['require']);
$this->assertSame('>=' . ext::MIN_PHPBB_VERSION, explode(',', $soft)[0]);
// Both caps allow phpBB 3.3.x and 4.0.x and stop at the same bound, so one cannot be changed without the other.
$this->assertSame('<4.1.0', explode(' ', $hard)[1]);
// The cap allows phpBB 3.3.x and 4.0.x.
$this->assertSame('<4.1.0@dev', explode(',', $soft)[1]);
}

Expand Down
Loading