Repository navigation
Add normalize-composer.py; smoke_test.py loads the ACP extension details page - #50
Merged
Merged
Conversation
…ils page normalize-composer.py brings an extension's composer.json to the phpbbmodders baseline: require.php >=8.3.36, composer/installers ^1.0 || ^2.0, no phpbb/phpbb in require, and soft-require from phpBB 3.3.19 with the upper bound ext.php enforces. It edits the file as text, keeping key order, indentation and line endings, and checks the parsed result before writing. tests/test-normalize-composer.sh covers it in CI. smoke_test.py now also loads the extension's ACP details page, where phpBB reads composer.json, and checks its display name shows there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
Merged
chore: composer.json baseline for phpBB 3.3.19 and PHP 8.3.36
phpbbmodders/activationjustification#7
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 5, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
bonelifer
added a commit
to phpbbmodders/phpbb-ext-wiki
that referenced
this pull request
Nov 6, 2026
Brings `composer.json` to the phpbbmodders baseline for phpBB 3.3.19 and PHP 8.3.36. Only these keys change; key order, indentation and line endings stay as they are. - Added `composer/installers` `^1.0 || ^2.0` after `php`. - `extra.soft-require` `phpbb/phpbb`: `>=3.3.19,<4.1@dev` → `>=3.3.19,<4.1.0@dev` (the upper bound keeps the phpBB 4.0 support this extension declares) Made with `normalize-composer.py` (phpbbmodders/phpbb-release-tools#50). **Testing** (by Claude): - `composer validate`: no errors, and no warnings the old file didn't have. - `smoke_test.py` on a phpBB 3.3.19 board: clean, including the ACP extension details page where phpBB reads `composer.json`. --- Investigated and written by [Claude](https://www.anthropic.com/claude) on behalf of William Jacoby ([bonelifer](https://github.com/bonelifer)). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools for the org-wide
composer.jsoncleanup (phpBB 3.3.19 / PHP 8.3.36 baseline).normalize-composer.pybrings an extension'scomposer.jsonto the baseline and changes nothing else:require.php→>=8.3.36composer/installers→^1.0 || ^2.0, added afterphpwhen missingphpbb/phpbbremoved fromrequire(it belongs only inextra.soft-require)extra.soft-requirephpbb/phpbb→>=3.3.19, with the upper boundext.phpenforces:<4.0.0@devwhenext.phprefuses 4.0,<4.1.0@devwhen it allows only up to 4.0 orsoft-requirealready declares 4.0 support, and none otherwise.--upperoverrides it.It edits the file as text, so key order, indentation (including mixed tabs and spaces), escaping and line endings stay as they are; single-line objects stay on one line. It parses the result and only writes when that equals the original plus exactly these changes.
--dry-runprints the changes without writing. With no arguments it prints help.tests/test-normalize-composer.shcovers a typical file, CRLF line endings, mixed indentation, a missingcomposer/installers, single-line objects, theext.phpceiling,--upper,--dry-run, a non-extension and bad arguments. It runs in CI.smoke_test.pynow also loads the extension's ACP details page (ACP > Manage extensions), where phpBB readscomposer.jsonthrough its metadata manager, and checks that the display name shows there.Testing (by Claude): the new tests pass and ShellCheck is clean. The script was run on 68 phpbbmodders extensions (all but trackers and bulkuseradd);
composer validateshowed no new errors or warnings in any of them, andsmoke_test.pywas clean on a phpBB 3.3.19 board for all 68, apart from three problems that are the same on their default branches (documentation, knowledgebase, topictags).Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code