Repository navigation
Download page: show only the modules in the selected Prebid.js version - #6843
patmmccann wants to merge 3 commits into
Conversation
Fetch the selected version's file list from jsDelivr and hide checklist entries for modules that aren't in it (falling back to showing everything if the list can't be loaded). Hidden but checked modules are left out of the download and reported. Also fix module names on 15 docs pages whose download checkbox didn't match any module file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12143e582f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…st loads Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Combined into #6842, together with the download page error handling, request timeouts and v8 cleanup. The commits are cherry-picked unchanged on top of #6844. |
The download page's module checklist showed every documented module, whatever version was selected. About 90 of the ~800 entries aren't in 11.43.0: mostly long-removed adapters (aol, districtm, spotx, ...), plus modules removed in 11.0. Selecting one only produced a build without it. This makes the checklist show only the modules in the selected Prebid.js version.
How it works
data.jsdelivr.com/v1/packages/npm/prebid.js@<version>?structure=flat). Module names are taken frommodules/<name>.(js|ts)andmodules/<name>/index.(js|ts). Checklist entries whosemoduleCodeisn't in the list are hidden.min_js_versioncheck.max-age=31536000). It's about 440 KB compressed per selected version.Docs naming fixes
15 pages had a download
moduleCodethat didn't match any module file. Those modules were silently missing from builds, and with this change they'd be hidden. Their front matter is corrected:modulecode: browsi, byData, datawrkz, im, liveIntent, nexx360, AsteriobidPbm.module_code: dynamicAdBoostRtdProvider, humansecurityRtdProvider, humansecurityMalvDefenseRtdProvider, agenticAudienceRtdProvider.useridmodule: adriverIdSystem, jixieIdSystem.filename:override (smbBidAdapter,synapsehxBidAdapter); theirbiddercodeis unchanged.Touching those analytics pages also meant fixing their existing markdownlint errors (heading levels, one code fence language).
Testing
Tested in headless Chrome against the live download page, with this
download.jsswapped in, the status line injected, and the versions service mocked (it's currently down, see #6839). Requests to jsDelivr were real:rubiconBidAdapteraolBidAdapter(removed long ago)paapi(removed in 11.0)This edits
assets/js/download.jsin different places from #6842, so the two shouldn't conflict.🤖 Generated with Claude Code