Repository navigation
Download page: filter modules by version, explain failures, add timeouts, drop v8 handling - #6842
Open
patmmccann wants to merge 6 commits into
Open
patmmccann wants to merge 6 commits into
patmmccann wants to merge 6 commits into
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 22, 2026
…rop v8 handling - If the version list can't be loaded, show an error box (with a link to building from source) and disable the download button, instead of only a dropdown entry. The DOM updates wait for the page to be parsed, since the request can fail first. - prebidBundler: time out registry and jsDelivr requests after 30s so a stalled request fails instead of leaving the page waiting forever. - Remove the Prebid.js 8.x module renames (gdprEnforcement, consentManagement, fledgeForGpt); the page only offers 10.0+ builds. - Update the stale "e.g. 3.x / 2.x" major version example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
patmmccann
force-pushed
the
agent-download-page-hardening
branch
from
October 22, 2026 18:48
2357ccd to
d90e0a8
Compare
Fetch the selected version's file list from jsDelivr and hide checklist entries for modules that aren't in it (falling back to showing everything if the list can't be loaded). Hidden but checked modules are left out of the download and reported. Also fix module names on 15 docs pages whose download checkbox didn't match any module file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…st loads Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download page follow-ups to #6839 and #6844. This now also includes #6843 (filtering the checklist by version), since both PRs were cleanup of the same page. #6843 is closed in favor of this one.
Fixes prebid/Prebid.js#9410
1. Show only the modules in the selected version (from #6843)
The checklist showed every documented module, whatever version was selected. About 90 of the ~800 entries aren't in 11.43.0: mostly long-removed adapters (aol, districtm, spotx, ...), plus modules removed in 11.0.
data.jsdelivr.com/v1/packages/npm/prebid.js@<version>?structure=flat). Checklist entries whosemoduleCodehas nomodules/<name>.(js|ts)ormodules/<name>/index.(js|ts)are hidden.I looked at using the bundler's
dist/chunks/dependencies.jsoninstead, which is about 7.5 KB. It only lists chunks that have dependencies, so about 160 real modules would be missing.checksums.jsonis complete but only exists from 11.40 onward.Docs naming fixes: 15 pages had a download
moduleCodethat didn't match any module file. Those modules were silently missing from builds, and with this change they'd be hidden. Their front matter is corrected:modulecode: browsi, byData, datawrkz, im, liveIntent, nexx360, AsteriobidPbm.module_code: dynamicAdBoostRtdProvider, humansecurityRtdProvider, humansecurityMalvDefenseRtdProvider, agenticAudienceRtdProvider.useridmodule: adriverIdSystem, jixieIdSystem.filename:override.The touched analytics pages also get their existing markdownlint errors fixed.
2. Version list failures are visible
If
prebidBundler.getVersions()fails (registry down, timeout, bad response):The DOM updates wait for the page to be parsed, since the request can fail first.
3. Request timeouts in
prebidBundler.jsRegistry and jsDelivr requests abort after 30s (
AbortSignal.timeout, skipped in browsers without it) and reject withTimed out retrieving <url>. Previously a stalled request left the button on "Sending Request..." forever.4. Remove the v8 handling
renameModulesmappedtcfControl/consentManagementTcf/paapiForGptto their 8.x names. The page only offers 10.0+ builds, so it's dead code and has been removed.Testing
I ran the live download page in headless Chrome, serving this branch's
download.jsandprebidBundler.js, with npm and jsDelivr requests going out live:aolBidAdapterhidden,rubiconBidAdaptershown.prebid11.43.0.js(251 KB, withuserIdadded as the parent) andprebid-config.json, with no requests to js-download.prebid.org.getVersions()rejected with "Timed out retrieving https://registry.npmjs.org/prebid.js".paapiwas visible. With the jsDelivr response delayed, the button stayed disabled until the listing loaded. With jsDelivr unreachable, all modules were shown.markdownlint-cli2 0.22.1 passes on all changed Markdown files. This merges cleanly with #6845.
🤖 Generated with Claude Code