Repository navigation
Reconcile Permutive consent docs with current master (follow-up to #6352) - #6885
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8b85ded99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ### Consent | ||
|
|
||
| While Permutive is listed as a TCF vendor (ID: 361), Permutive does not obtain consent directly from the TCF. As we act as a processor on behalf of our publishers consent is given to the Permutive SDK by the publisher, not by the [GDPR Consent Management Module](/dev-docs/modules/consentManagementTcf.html). | ||
| If you are also using the [TCF Control Module](/dev-docs/modules/tcfControl.html), by default Permutive will not be blocked as it will rely on the publisher's consent signals to read from storage. If you choose to gate Permutive on vendor ID 361, add that vendor ID to your CMP and pass `enforceVendorConsent` to the module's configuration. |
There was a problem hiding this comment.
For publishers who opt into vendor-361 gating, this is not a usable configuration instruction: enforceVendorConsent appears in neither the provider sample nor the parameter table, leaving its nesting, type, value, and default unspecified. A plausible top-level placement can be ignored and leave the advertised vendor check disabled; document params.enforceVendorConsent as a Boolean with its default and show true in the example, and likewise add it to the Identity Manager example.
AGENTS.md reference: AGENTS.md:L15-L15
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in commits 602c565 and 8fe17d8. I added params.enforceVendorConsent to the RTD parameter table (Boolean, default false) and included explicit params: { enforceVendorConsent: true } examples for both RTD and Identity Manager. Confirmed the nesting and default against modules/permutiveRtdProvider.js, modules/permutiveIdentityManagerIdSystem.js, and the RTD TypeScript configuration interface. I'm responding on the PR author's behalf as ChatGPT, not as the author personally.
| ### Consent | ||
|
|
||
| While Permutive is listed as a TCF vendor (ID: 361), Permutive does not obtain consent directly from the TCF. As we act as a processor on behalf of our publishers consent is given to the Permutive SDK by the publisher, not by the [GDPR Consent Management Module](/dev-docs/modules/consentManagementTcf.html). | ||
| If you are also using the [TCF Control Module](/dev-docs/modules/tcfControl.html), by default Permutive will not be blocked as it will rely on the publisher's consent signals to read from storage. If you choose to gate Permutive on vendor ID 361, add that vendor ID to your CMP and pass `enforceVendorConsent` to the module's configuration. |
There was a problem hiding this comment.
On Prebid.js releases from before the related source change introduced enforceVendorConsent, the new default and flag do not exist; those builds still need the removed vendorExceptions entry for permutive when vendor consent for 361 is unavailable. The page continues to give explicit 7.13/7.29-era guidance, so an older-build integrator following this replacement can have all cohort reads blocked; state the first supporting release and retain the legacy instructions for earlier versions.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in commits 602c565 and 8fe17d8. Verified that the feature was introduced in Prebid.js 10.19.0 (present in that tag, absent in 10.18.0; upstream commit prebid/Prebid.js@1f0764c). The RTD docs now retain the legacy vendorExceptions: ['permutive'] configuration with a privacy warning for older builds, and both pages distinguish pre-10.19.0 behavior from the newer publisher-purpose-consent default. I'm responding on the PR author's behalf as ChatGPT, not as the author personally.
Supersedes #6352, whose contributor fork branch cannot be updated with current permissions (GitHub 403).
msft/custom cohorts andparams.bidders.This is a fresh branch off current
master, intended as a conflict-free alternative to #6352. Please review theenforceVendorConsentbehavior against the related Prebid.js change before merging.Related: #6352; patmmccann/Prebid.js#319.