Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 6e415ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
integration-tests: recommended
Contributor
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
adierkens
added
the
Canary Release
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
adierkens
changed the title
1 of 5 tasks
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to github/core-ux#4233
Prototype element
renderAnchorcomposition and explicit Tooltip routing/visibility through@primer/react/experimental, without separate Root/Trigger components. Stable APIs remain unchanged.Changelog
New
ActionMenu,AnchoredOverlay, andTooltipmerge element refs, handlers, styles/classes, and ARIA ID lists onto one trigger; callbacks remain escape hatches.popupProps, tooltip-onlydisabled, andopen/defaultOpen/onOpenChange(next, details). Suppression overrides visibility without disabling the trigger; the private alias remains compatible.Changed
HTML props configure the experimental Tooltip trigger in both children and render modes; move bubble attributes into
popupProps. Primer retainspreventDefault()cancellation and ARIA ID merging rather than Base UI's exact merging semantics. Configured anchors and the original overlay object-ref callback are preserved; SelectPanel remains out of scope.Removed
None from the stable API.
Rollout strategy
Testing & Reviewing
Latest suppression fix:
npm run build,npm run type-check,npm exec --offline -- vitest run --project @primer/react packages/react/src/experimental/TriggerComposition/TriggerComposition.test.tsx packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx(64 passed, 2 skipped), targetednpm exec --offline -- eslinton the four changed TSX files,npm run format:diff, andgit diff --checkpassed. The updated menu story was exercised in Chromium: suppression closes/blocks the bubble, preserves the enabled trigger and accessible description, and permits fresh-hover reopening after menu dismissal without a second visibility state.Prior full checks at
515add0d0:npm test(164 files, 3,128 passed),npm run lint,npm run lint:css, andnpm run lint:npm --workspace @primer/reactpassed; three stories and MDX rendered, and GitHub axe including contrast passed four states. Unchanged broad checks were not repeated for the wrapper-only suppression fix. Manual screen-reader, canonical AVT/VRT, and complete atomic accessibility review remain outstanding; configured Storybook MCP is unavailable. React 19 ref-cleanup coverage is conditional under the React 18 runner.