Channels last: preserve metadata across op replacement - #21923
Draft
rascani wants to merge 1 commit into
Draft
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21923
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 06f4f6d with merge base ed2d9ec ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 18, 2026
This PR needs a
|
rascani
marked this pull request as draft
August 18, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Preserve the complete metadata dictionary when replacing an ATen operator with its channels-last dialect counterpart. ExportPass retracing recomputes layout-dependent shape fields such as val and tensor_meta, while source attribution and backend annotations such as debug_handle, from_node, input_qparams, output_qparams, and custom metadata survive the rewrite.
Document the remaining caller contract in terms of every input and output listed by ChannelsLastOpSpec. Semantic metadata tied to a permuted dimension, such as a per-channel quantization axis, must be rejected or remapped by the backend before replacement. This keeps provenance preservation as the default without implying that a metadata allowlist validates layout semantics.
Keep structural-layout helper definitions out of this change; the following optimizer Diff introduces them when they gain multiple consumers. Convert the existing Buck test target to pytest-aware discovery and add coverage for provenance survival together with recomputed NHWC output shape.
Differential Revision: D116372280