Repository navigation
fix(family): align uniform hair physics across outfit switches - #62
Merged
Merged
Conversation
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uniform outfit switches used different hair physics from office, causing a visible jump. Apply the accepted office hair/bang profile to all five uniform configs and their guarded reproduction stage: 75 constraints, five scalar fields each. Rebuild uniform authoring and serving representations while preserving every other field, geometry, images, atlas, motion and other-outfit bytes.
The initial matched cut differed by 53,272 non-clothing pixels outside the neck union. Physics parity reduced this to 358 on Linux (357 in a bounded macOS replay), but exact screenshot zero remained red. After inspecting the 4× sheet, HQ explicitly restated the acceptance bar to match the issue's hair-motion aim: every shared draw has exactly equal posed coordinates across the switch, supported by the viewed sheet and cold shared-atlas control (0 pixels). All 73 shared draws / 2,966 coordinate scalars match exactly. Raster residuals depend on atlas sampling and draw-set/batch state; they are tracked in play#187. No pixel-zero claim, mask expansion or tolerance change is made.
Viewed sheet:
family/docs/uniform-hair-switch.png, SHA256bd46337ef39f333d7e8a03818524dc8f4b4a562b31ceda35d415f07c621cd8c5. Compact receipts and a pinned-player pose verification command are committed. The original candidate job remains exit 1 under its superseded pixel-zero assertion; the final full acceptance run is separate and exit 0.Validation: targeted 7/7, serving allowlist 25 controls, whole-chain actual-reader dry run, then final Nova exit 0: 48/48 regressions, 20 rigs / 396 reproduction rows, five official build/check gates pass. Mesh/UV/weights/atlas/image/motion bytes and other outfits remain unchanged. Existing live-physics/stress and absent-eyewhite exclusions remain documented. No new subjective fidelity or physical-device acceptance is claimed.
Scope is uniform only. Same-setup homewear (52,623 pixels) and swimwear (52,986) measurements are read-only findings for a separate followup after landing.
Closes #49.