Repository navigation
docs: render the accepted Character 1 idle at 492 pixels wide - #64
Merged
Merged
Conversation
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8422d447d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29. Add a predictor-optimized, lossless 492×1290 APNG of the accepted Character 1 idle, preserving 41 frames and exact 1/12-second delays. The trial includes pinned inputs, reproduction commands, sheet, measured receipt and CHECKPOINT. Existing files and family/ are unchanged.
Loop definition adopted for this card: the last-to-first RGB mean absolute difference must not exceed the largest adjacent-frame difference. Measured wrap is 0.443599 versus maximum adjacent step 0.759750: PASS. rigc emits no closure verdict; this is the measured wrap. Exact endpoint identity is not this physics-idle bar; endpoints differ (max RGB 212). Repeat metadata is infinite, independently checked. No frames were dropped, replaced or blended, and no physics/motion/rig was changed.
The original
--max 1280output was 488 pixels wide. Minimal--max 1290reaches 492 without reframing. All 41 decoded RGBA frames match the renderer. Timing is exactly 41 × 1/12 seconds. Both 41-frame producer sets were concat-hash verified then deleted after the sheet verdict.Selected SHA-256:
bd31ad5b7d952733417a8ac830c40e73719f95ef0cdb8569e092c2bde3161f0e.Staged Nova execution passed producer → actual downstream-reader/control dry-run → encoding/independent decode; optimization reused the existing artifact without rerendering. The AI review's P2 reproduction-path finding was fixed: absolute trial-tool root and explicit accepted-input root remain separate; setup verifies pinned input hashes. Actual README setup, isolated install and renderer loader passed. The review reply/thread is resolved with evidence. No full suite or browser playback was run; final CI status is checked separately.