Repository navigation
fix(family): align homewear and swimwear hair at outfit switches - #65
Merged
Merged
Conversation
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homewear and swimwear retained the earlier hair profile, so outfit switches displaced shared hair. Transfer the accepted office hair/bang values to all ten configs and their guarded reproduction stage: 150 constraints × five fields. Preserve every other field, geometry, images, UVs, atlas/pages, motion, office and uniform bytes.
Fresh matched measurements on the landed baseline reproduce the earlier figures: homewear 52,623→401 and swimwear 52,986→370 differing pixels outside the unchanged neck union. The complete shared pose now matches exactly: 73 draws per outfit, 146 total. Both cold shared-atlas controls are 0. Two viewed 4× sheets and source/hash-bound receipts are committed. Screenshot zero is not claimed; the motion-versus-raster bar follows #49's explicit HQ ruling, with raster residuals owned by play#187.
Validation: final targeted 12/12, allowlist 50 controls, exact-packet sequential actual-reader dry run, then final Nova exit 0: 50/50 regressions, 20 rigs / 396 parts reproduce, all five office official build/check gates PASS. All 3,244 other baseline files are byte-identical; full-object allowlists restrict changes to physics coefficients and derived model hashes. Existing live-physics, stress, absent-eyewhite and reported-source-comparison exclusions remain explicit. No new subjective fidelity or device claim.
ops/63/CHECKPOINT.mdrecords frozen evidence and the remaining review/CI/landing gates so work can resume after an interruption.Closes #63.