Repository navigation
fix(family): state the hand mesh repairs of Characters 1, 2, 4 and 5 in their configs - #68
Conversation
… the producer output The committed Character 1 build carried hand-repaired meshes for bottomwear, topwear and hair_front that its config could not state, so nobody could rebuild the example and get the example. @rig-c/parts 1.62.0 carries the explicit mesh payload (#718), so the config now states all three as meshes.<part>.explicit (uvs, triangles, weights, hull, bone-name segments, image and region hashes), and the producer output is committed. A fresh rig-parts rig --config at 1.62.0 reproduces all 20 producer files byte-for-byte (re-run by HQ). The topwear payload equals the accepted repair (sha256 741a1b7d...); rig.json is the same object as before in the producer's print format (718,344 -> 514,965 B); topwear.png has identical decoded RGBA in the producer's canonical encoding; motion and the other 16 images are byte-identical. check PASS; verify-accepted PASS on all 20 rigs; 13/13 tool tests. Closes #31 Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
💡 Codex Reviewexamples/family/roa/config.json Lines 3219 to 3221 in 926b4b6  Preserve bust-region editing when migrating topwear to explicit meshes
Replacing ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
HQ: the Codex P2 is adopted as a real defect, since it reproduced the KeyError and the viewer dereference. The fix goes into the stacked #69 work: every reader of |
…ion tools working on explicit meshes Characters 2, 4 and 5 now state their hand mesh repairs as meshes.<part>.explicit at @rig-c/parts 1.62.0, and a fresh producer build reproduces every producer file (HQ re-ran all three: 0 differing files). Character 4's hair_back adopts the producer's _d bindings: its config declares stops on hairback_r/l and the committed weights had been pasted from before applyStops, so the declaration wins (check PASS, 10/10 bars). Character 5's config drops four cuff physics constraints the accepted rig and cuff-physics.json never had. Character 3 stays on declared repairs: its parts split across island slots, which explicit cannot state yet (rig-c/parts#734). Review fix (Codex P2 on #68): moving topwear off contour broke the repository's region tooling. read_all_regions returned {} and the rebuild raised KeyError('contour'). Each reader now resolves the pre-explicit contour from declared-repairs.json (regenerated.meshConfig), the rebuild and wave-author tools refuse an explicit mesh by name (FAMILY_EXPLICIT_MESH_REFUSED, naming what to edit instead), and the viewer no longer dereferences a missing region. 51/51 tool and viewer tests; verify-accepted PASS on all 20 rigs. Refs #69 Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
|
HQ: this PR now carries #69 as well (899df7a, stacked on 926b4b6). Characters 2, 4 and 5 are migrated the same way as Character 1. HQ independently rebuilt all four: 0 differing producer files. Character 3 is blocked on rig-c/parts#734 (a part split across island slots), so #69 stays open for it. The Codex P2 above is fixed in 899df7a:
The KeyError was reproduced before the fix and is gone after it. Tool and viewer tests: 51/51. |
firejune
changed the title
The committed Character 1 build carried hand-repaired meshes for
bottomwear,topwearandhair_frontthat its config could not state. @rig-c/parts 1.62.0 carries the explicit mesh payload (rig-c/parts#718), so the config now states all three asmeshes.<part>.explicitand the producer output is committed. Bars as amended on #31:rig-parts rig --configat 1.62.0 vs committedout/rig/741a1b7d…rig.jsonmotion.jsonrig-parts checkverify-accepted.mjsnode --test verify-accepted.test.mjsThe other four characters keep their existing declared repairs until they get their own migration cards.
Closes #31
🤖 Generated with Claude Code