Repository navigation
fix(family): state Character 3's island repairs in its config; retire the island post-passes - #70
Merged
Merged
Conversation
… the island post-passes Character 3's earring and front hair were split across island slots by two post-pass scripts that edited rig.json after rig-parts, so the config could not state them. @rig-c/parts 1.63.0 carries meshes.<part>.explicit.islands (rig-c/parts#738): earring (19v + 10v island) and hair_front (79v on the head and bangs + a 26v island on head placed before ear_l) are now stated in the config, and a fresh producer build reproduces every producer file (HQ re-ran it: 0 differing files). check PASS 11/11 with the setup seam at 0 px over 40 including the before-ear_l island. clip-field-islands-guarded.ts and apply-jinni-behind-ear-strand.ts are retired: no character uses them now. verify-accepted PASS on all 20 rigs; 13/13 tool and 38/38 viewer tests. Closes #69 Co-Authored-By: Jinni <342598851+fj-jinni[bot]@users.noreply.github.com> Co-Authored-By: Roa <342598975+fj-roa[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Character 3's earring and front hair repairs are now
meshes.<part>.explicit.islandsat @rig-c/parts 1.63.0. A fresh producer build reproduces every producer file (HQ re-ran it: 0 differing files). The two post-pass scripts that made the island slots are retired, and no character uses them any more. That was the success bar HQ set on rig-c/parts#734.before: ear_lorder)rig-parts checkverify-acceptedWith this, all five family characters build from config alone.
Closes #69
🤖 Generated with Claude Code