Repository navigation
fix(dancer): adopt explicit skirt and add mesh-only v4 replay - #72
Conversation
Carry the selected mesh through the published parts producer, freeze its byte/RGBA inventory, and retain the prior keeper for historical dance replay. Add an explicit v4 candidate with unchanged motion and all other rig subtrees; keep v3 as default pending owner acceptance. Record fresh production, native editor roundtrip, fixed-viewport metrics and video receipts. Co-Authored-By: Naru <342599188+fj-naru[bot]@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
LGTM #72 at |
Change
The config producer's generated skirt fails the unchanged setup seam. Adopt the selected explicit mesh at parts 1.64.0, retain its turn depth, and freeze 31 producer files with byte and decoded-RGBA verification. Archive the former keeper so historical v1/v3 replay remains source-bound.
Separately add opt-in accepted-dance/v4: only the bottomwear attachment changes from v3; literal motion bytes and every other rig subtree remain identical. V3 stays the default pending owner eye acceptance. This is the two-delivery scope recorded in #71; the producer lacks the accepted dance's alternate/control bones, so its dance metrics are inapplicable.
Evidence
Bones remain identical by name in the producer; raw order swaps two turn bones and the matching transform bone list. Physics and motion remain identical. This explicit scope amendment replaces the initial raw-array identity requirement. Native editor rewrites are reported, not claimed byte identity; macOS does not provide the Linux descendant-boundary proof, and no Spine processes remain.
Known shins folds remain 269 frames. V4 silhouette deviation against accepted v3 is 15.425046px max (including 14.164224px setup shift); the earlier 4.6px figure used another baseline. The mesh reduces the stair artifact, without claiming elimination.
The owner video was delivered privately: 51 frames f240–290, full figure and both flanks at 4x nearest, 3072x1600 H.264, SAR 1:1, 1,367,689 bytes. Its receipt and small comparison sheet are tracked; 782 native PNGs were hash-checked and deleted after sheet review. Owner verdict and HQ exact-head sign remain merge gates. No renderer patch, track drop, control alias, family tool change or private measurement scripts are included.
Closes #71.
@codex review