We no longer need enable packs to be Flippered - #5642
Merged
awwaiid merged 4 commits intoAug 29, 2026
Conversation
stefannibrasil
force-pushed
the
sb-remove-enable-packs-feature-flag
branch
from
August 28, 2026 21:38
28da2ef to
d7fcfe0
Compare
stefannibrasil
marked this pull request as ready for review
August 28, 2026 21:45
Contributor
Author
|
@dorner thanks for merging the related PR. This one does not have any failures 💅🏼 Ready for review when you are, thank you! |
3 tasks
awwaiid
added a commit
that referenced
this pull request
Aug 29, 2026
…ature-flag Remove enable_packs feature flag (builds on #5642)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5251
Description
"Enable packs" is now in service, and we no longer need it to be Flippered. This PR adjusts the code so that enable packs is no longer needed to be turned on, and defunct code is removed.
Follow up of #5643
Type of change
How Has This Been Tested?
#5643 added more coverage for the missing paths for when the feature flag was enabled. Tests descriptions have been updated to expect for the flipper behaviour to be always on.