Skip to content

ci: add seidroid review workflow - #55

Merged
amir-deris merged 1 commit into
mainfrom
amir/plt-1554-add-seidroid-review-to-sei-config
Oct 30, 2026
Merged

amir-deris merged 1 commit into
mainfrom
amir/plt-1554-add-seidroid-review-to-sei-config

Conversation

@amir-deris

@amir-deris amir-deris commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Resolves PLT-1554.

Adds .github/workflows/seidroid.yml. It's copied unchanged from sei-k8s-controller and calls sei-protocol/uci/.github/workflows/seidroid-review.yml, pinned at v0.0.27. It sets up three jobs:

  • review: runs automatically when a PR is opened, updated or reopened, or on a @seidroid review comment. It reviews against CLAUDE.md and approves when the result is clean.
  • close: a @seidroid review close comment tears down the PR's session.
  • reclaim: reclaims the sandbox when the PR closes.

Commenting is limited to sei-protocol/sei-core, and Dependabot runs are skipped.

Before this works

  • Org admin: make the org secrets PLATFORM_CODE_AGENT_APP_ID and PLATFORM_CODE_AGENT_APP_PK visible to sei-config.
  • Add OMNIGENT_MACHINE_CLIENT_SECRET as a repo secret.
  • Install the seidroid / platform-code-agent GitHub App on sei-config.

Until these are done, the seidroid jobs on this PR will fail.

Wire the seidroid reviewer the same way sei-k8s-controller does: an
automatic review on pull request events, `@seidroid review` /
`@seidroid review close` on comment, and a reclaim of the sandbox when
the pull request closes. Reviews against CLAUDE.md, since this
repository keeps no REVIEW.md.

Refs PLT-1554

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Adds CI-only workflow wiring with no application code changes; operational risk is mainly misconfigured secrets or fork PRs where GitHub withholds secrets (documented in the workflow).

Overview
Adds .github/workflows/seidroid.yml, wiring this repo into the shared seidroid PR review automation via sei-protocol/uci/.github/workflows/seidroid-review.yml (pinned v0.0.27).

Review runs on PR open/update/reopen and on @seidroid review comments (not Dependabot-only runs), uses CLAUDE.md as review guidelines, approve-on-success: true, and restricts who can trigger comments to sei-protocol/sei-core. Close and reclaim jobs tear down review sandboxes on @seidroid review close and when a non-Dependabot actor closes the PR, respectively. Each job passes org/repo secrets for the platform code agent and Omnigent machine client, with scoped pull-requests/checks/issues write permissions.

Reviewed by Cursor Bugbot for commit abddd81. Bugbot is set up for automated code reviews on this repo. Configure here.

@seidroid seidroid Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a thin caller workflow that wires automatic and comment-triggered seidroid review, plus session close and reclaim, to the pinned sei-protocol/uci reusable workflow at v0.0.27. The triggers, permissions and secret passing match what the pinned workflow expects, and its guard still enforces the team, fork and draft checks, so nothing blocks; codex's one finding was checked and dropped because the reusable workflow never opens a session for a fork PR, so there is nothing left to reclaim.

1 nit, not posted on the code
  • .github/workflows/seidroid.yml:67 — This comment says to run @seidroid review close on a fork PR before merging, and the PR description says the same. That step should never be needed: the pinned uci guard refuses to review a fork-originated PR on both the automatic and the comment path, so no sandbox is ever created to leave running. The only fork-related effect is a failed reclaim run, which has nothing to clean up.

seidroid review · decision approve · session ad61d92acb8542febbf46c84a52ace18 · turn resp_claude_ce85a2d45c583334a1cbcef47f9f8905 · item fd4448d5be2c54d299642dfb243ed67e

Findings: 0 blocking | 0 non-blocking | 0 posted inline

@amir-deris amir-deris self-assigned this Oct 30, 2026
@amir-deris
amir-deris merged commit 0c2741b into main Oct 30, 2026
9 checks passed
@amir-deris
amir-deris deleted the amir/plt-1554-add-seidroid-review-to-sei-config branch October 30, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants