improvement(settings): drop the Privacy row's description - #6844
Conversation
The row reads Privacy settings with a Manage chip, and the sub-view it opens titles and describes itself — the sentence beneath it restated that before the user had asked for it. The wrapper it shared with the row goes too, now that the row is the section's only child.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The row still shows Privacy settings with a Manage chip that opens Reviewed by Cursor Bugbot for commit a33f385. Configure here. |
Greptile SummaryRemoves the redundant description beneath the Privacy settings row and simplifies its markup while preserving the existing Manage action.
Confidence Score: 5/5The PR appears safe to merge with no actionable issues identified. The simplified markup matches sibling settings rows, preserves the Manage action, and does not violate the surrounding section’s layout contract.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/settings/components/general/general.tsx | Simplifies the Privacy section to match other single-row settings sections without changing behavior. |
Reviews (1): Last reviewed commit: "improvement(settings): drop the Privacy ..." | Re-trigger Greptile
Summary
Removes the description under the Privacy settings row in General settings.
The row already reads "Privacy settings" with a Manage chip, and the sub-view it opens carries its own title and description ("Privacy — Control what Sim collects about how you use it."). The sentence beneath the row restated that a step before the user had asked for it.
Also drops the
flex flex-col gap-3wrapper the paragraph shared with the row — with the paragraph gone, the row is the section's only child and the wrapper does nothing.Note the Account section below keeps its description on purpose: "Delete account" is destructive and irreversible, so the consequence belongs on the row rather than one click away.
Type of Change
Testing
type-check,lint:check, all 29check:audits, and 199 tests pass. No behavior change —isHostedis still imported and used by the Home page action above.Checklist