fix(chat): preserve queued edits and render quoted source chips - #7452
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR coordinates composer mode and Search URL updates so queued edits retain their content, and makes chat-chip sanitization preserve backticks inside JSON strings.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/chat-content/chat-sanitize.ts | Introduces a bounded JSON-aware scan that preserves backticks inside source and workspace-resource payloads without consuming neighboring Markdown delimiters. |
| apps/sim/app/workspace/[workspaceId]/home/hooks/use-mothership-mode.ts | Centralizes mode, query, and Search-filter updates into one URL-state operation when leaving Search. |
| apps/sim/app/workspace/[workspaceId]/home/components/user-input/user-input.tsx | Adds an explicit Search-exit text reset while preserving attachments and prevents an empty URL seed from overwriting a restored queued message. |
| apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/mode-switcher/mode-switcher.tsx | Delegates composer cleanup to UserInput before applying the shared atomic mode transition. |
| apps/sim/app/workspace/[workspaceId]/home/home.tsx | Relies on the shared mode transition to clear Search state during queued-message restoration and result summarization. |
| apps/sim/app/workspace/[workspaceId]/home/search-params.ts | Defines the combined parser set used to update mode and Search parameters atomically. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Search composer] --> B{User action}
B -->|Choose Build or Assistant| C[Clear editor search text]
C --> D[Atomically update mode and remove q/source/updated]
B -->|Edit queued message| E[Restore queued request mode]
E --> D
D --> F[Load queued text and attachments]
G[Chat response text] --> H[JSON-aware chip delimiter scan]
H --> I[Preserve payload backticks]
I --> J[Render source or resource chip]
Reviews (2): Last reviewed commit: "fix(chat): preserve queued edits and ren..." | Re-trigger Greptile
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 23 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
waleedlatif1
force-pushed
the
codex/fix-release-7446-review
branch
from
September 3, 2026 21:16
2bba034 to
605b3b6
Compare
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Knowledge access, Slack, and related documentation fixes from #7446 are covered separately by #7451.
Type of Change
Testing
Passed 189 focused tests across six suites, all 45 repository audits, lint, docs-manifest validation, and the app type-check. Regression assertions fail against the previous behavior. The retained changes completed all eight cleanup passes and a simplification review; malformed chip inputs also retain bounded scanning behavior.
Checklist