Repository navigation
Conversation
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
Work in progress. This tests whether the Solid 2 tutorial and playground can live in the docs, following the discussion about devagrawal09/solid-site#1.
The docs site runs on Solid 1.9, and the Solid 2 playground UI (
solid-repl) is a Solid 2 component, so it cannot be imported directly. This PR embeds the hosted playground in an iframe instead. A new<Playground code={...} />MDX component compresses the files into the playground's/#<lz-string tabs>URL and adds animport_map.jsonthat pinssolid-js@2.0.0-rc.18. The reactivity page uses it under "Try it: a shipping estimate", loading theLineItemstarter fromsrc/playgrounds/line-item.tsxwith a?rawimport. That folder is excluded fromtscand ESLint because it holds Solid 2 code.The deploy preview will show the playground's default counter rather than
LineItem. The live playground.solidjs.com writes the hash files to localStorage after it has already loaded the scratchpad, then its autosave overwrites them. solidjs/solid-playground#201 reloads the scratchpad after a hash import, which fixes it.VITE_PLAYGROUND_URLlets a build point at another playground host until that is deployed.Verified locally: built solid-playground#201 (
2b803dd) and served it on port 4174, then ranVITE_PLAYGROUND_URL=http://127.0.0.1:4174/ pnpm buildand serveddist/. In Chromium, the embed loadedLineItem, fetchedsolid-jsand@solidjs/web2.0.0-rc.18 from esm.sh, and the preview updated on click.pnpm check:types,pnpm check:lintand Prettier pass.pnpm check:exampleswas not run because it needs a local Solid checkout.Open:
2.0.0-rc.18.Related issues & labels
🤖 Generated with Claude Code