Repository navigation
Fix two files that stopped compiling after the e32319b21 header sync - #372
Merged
Merged
Conversation
The Ghidra sync e32319b renamed DAT_00b95954 to INT_00b95954 (an int now). playDarMehqOrGlory and switchToMenuView still included and named the old one; they move to main's name. No header or status line changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gynt
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main (e32319b) has two
.cppfiles that no longer compile in a clean build: the Ghidra sync e32319b renamedDAT_00b95954toINT_00b95954(and declared itint), and these files still include and name the old one. This PR moves them to main's name and changes nothing else: no header and no status line. Both functions stay at 100%, the same as their status lines. They're the only uses of the old name left on main.Audio/mss/SoundSystem/playDarMehqOrGlory.cppDAT_00b95954INT_00b95954Game/GameCore/switchToMenuView.cppDAT_00b95954INT_00b95954The include lines follow the name, sorted by clang-format.
Built with the bundled MSVC1400-SP1, natively on Windows, against the Steam
Stronghold Crusader.exe(3bb0a8c1…5387ac5a). With this PR every.cppundersrc/OpenSHCbut three compiles and the DLL links; the merges of #348 and #353 brought back main's other files that the eef6f66 sync had broken. Both functions read 100.0% with sourcehold's reccmp (--resolve-wrapped-calls --ignore-security-cookie, the struct resolvers enabled locally and not committed), andstatus_regression.pyfinds nothing below a known score. The three left out are the ones the twodata.asmentries described in #368 still keep from linking (TicksStartCounter, TicksSinceCounterStart, initializeDirectPlayAndCreateOrJoinSession).The same kind of fix as #343, #350 and #368. Our open #369, whose header commit had typed this global, gets main merged in with the new name.
Other PRs: the ready #354, #369 and #370, and the drafts #313, #318, #321, #327, #328, #356, #360 and #363.
🤖 Generated with Claude Code