Repository navigation
Conversation
Splunk drops a single backslash before an ordinary character in tstats and search patterns, so these patterns did not match the paths they name. Double them as in the neighbouring patterns, bump the version of each detection and set its modification date. Fixes splunk#4417
TT5H
requested review from
P4T12ICK,
RavenTait,
ljstella,
nasbench,
onurmerdogan,
patel-bhavin,
pyth0n1c,
rosplk and
tccontre
as code owners
November 16, 2026 17:51
Varunpoojari
approved these changes
Nov 16, 2026
Varunpoojari
left a comment
There was a problem hiding this comment.
Thanks for taking this on and for testing each one in Splunk, the table makes the effect of every change clear.
I read the diff: each file only doubles the lone backslashes and bumps version and modification_date. The #4417 line is identical to the fix I had made locally, and the other five match the patterns I'd flagged. Good call leaving out Registry Keys Used For Persistence; I'll look at the registry_key_name / registry_value_name issue there separately.
4 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4417.
Details
In
tstatsandsearchpatterns, Splunk drops a single backslash before an ordinary character, so*\Microsoft\Windows\EventLog\*behaves like*MicrosoftWindowsEventLog*. Six detections have a pattern written that way next to correctly doubled ones. This change doubles the lone backslashes and bumpsversionandmodification_date. Nothing else changes.I tested in Splunk Enterprise 9.3.14 (Splunk_SA_CIM 6.4.0, Splunk_TA_windows 9.1.2, Splunk_TA_microsoft_sysmon 5.0.0). I ran the published search and the fixed search on the test recording of each detection, and on a copy of one recorded event with a single field changed ("changed event"). A changed event that matches a correctly written pattern gave the same result in both versions.
*\Microsoft\Windows\EventLog\*Policies\...\EventLog\Setupvalue*\\Windows\Temp\\*C:\Windows\Temp\version.dll: not returnedtstatspart, because my instance had nohijacklibs_loadedlookup*\MpCmdRun.exeC:\Users\Administrator\Desktop\fakeMpCmdRun.exe: not returned, as if it wereMpCmdRun.exeProgram Files\Mozilla Firefox,Program Files (x86)\Mozilla Firefox,Cyberfox\cyberfox.exe)C:\Program Files (x86)\\FileZilla FTP Client\\filezilla.exe*\Werfault.exe...\evilWerFault.exeI left out
Registry Keys Used For Persistence, which has the same lone backslash in\CurrentControlSet\Control\Session Manager. Its conditionregistry_key_name="BootExecute"cannot match Sysmon data either way: the data model putsBootExecuteinregistry_value_name.A scan of all 2,213 detection searches for a single backslash before a letter in a path pattern, outside regular expressions, found no other file.
I left the other checklist items open. Each file changes only
version,modification_dateand onesearchline, and CI has not run yet.Checklist
<platform>_<mitre att&ck technique>_<short description>nomenclatureNotes For Submitters and Reviewers
buildCI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.