Repository navigation
ci: give the release comparison its own one-model edit limit - #1040
Merged
Merged
Conversation
One-model edit compiles may run up to 1.25x the previous release until native rendering is the default; cold and warm compiles keep 1.15x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since #1030, a one-model edit recompiles the edited model uncached until native rendering is the default. The release comparison holds every compile command to 1.15x, so its dense one-model edit check failed at 1.232x wall and 1.193x CPU, which would block the next release on an accepted trade-off.
Changes
MAX_EDIT_COMPILE_TIME_RATIOof 1.25x, applied to the wall and CPU time of both one-model edit commands (compile (one-model edit)anddense compile (one-model edit)). This mirrors--edit-max-ratioin the same-runner job.Verification
tests/unit/scripts/release_performancemake check-ci, hygiene scan