Skip to content

ci: give the release comparison its own one-model edit limit - #1040

Merged
kvlonge merged 1 commit into
mainfrom
ci/release-edit-limit
Oct 8, 2026
Merged

kvlonge merged 1 commit into
mainfrom
ci/release-edit-limit

Conversation

@kvlonge

@kvlonge kvlonge commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Why

Since #1030, a one-model edit recompiles the edited model uncached until native rendering is the default. The release comparison holds every compile command to 1.15x, so its dense one-model edit check failed at 1.232x wall and 1.193x CPU, which would block the next release on an accepted trade-off.

Changes

  • New MAX_EDIT_COMPILE_TIME_RATIO of 1.25x, applied to the wall and CPU time of both one-model edit commands (compile (one-model edit) and dense compile (one-model edit)). This mirrors --edit-max-ratio in the same-runner job.
  • Cold and unchanged-warm compile commands keep the 1.15x limit; other commands and the RSS limit are unchanged.
  • A workflow comment says the edit limit tightens back to 1.15x once native rendering is the default.

Verification

  • New verdict tests on the configured commands: edits within 1.25x pass, edits above it fail, and warm and cold compiles still fail above 1.15x
  • tests/unit/scripts/release_performance
  • make check-ci, hygiene scan

One-model edit compiles may run up to 1.25x the previous release until
native rendering is the default; cold and warm compiles keep 1.15x.
@kvlonge
kvlonge enabled auto-merge (squash) October 8, 2026 17:55
@kvlonge
kvlonge merged commit ef51849 into main Oct 8, 2026
25 of 26 checks passed
@kvlonge
kvlonge deleted the ci/release-edit-limit branch October 8, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant