Repository navigation
ci: widen the release comparison's one-model edit limit to cover runner noise - #1041
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release comparison's one-model edit limit (1.25x, added in #1040) sits inside runner-to-runner noise: the dense one-model edit measured 1.232x and then 1.289x wall against the previous release on consecutive runs, while CPU stayed within the limit. Edited models now recompile uncached by design, so this would block releases on noise rather than a regression.
Changes
MAX_EDIT_COMPILE_TIME_RATIOfrom 1.25x to 1.35x for the one-model edit commands only. Cold, unchanged-warm and non-compile commands keep their limits.Verification
tests/unit/scripts/release_performance(47 passed)