Skip to content

ci: widen the release comparison's one-model edit limit to cover runner noise #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvlonge merged 1 commit into from
Oct 8, 2026
Merged

ci: widen the release comparison's one-model edit limit to cover runner noise #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-performance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
run: uv sync --locked --all-groups --all-extras
- name: Build candidate wheel
run: uv build --wheel --out-dir "${RUNNER_TEMP}/candidate"
# Temporary: one-model edit compiles use MAX_EDIT_COMPILE_TIME_RATIO (1.25x) because an edited
# Temporary: one-model edit compiles use MAX_EDIT_COMPILE_TIME_RATIO (1.35x) because an edited
# model recompiles uncached; tighten it back to 1.15x once native rendering is the default.
- name: Compare candidate and previous release on this runner
env:
Expand Down
2 changes: 1 addition & 1 deletion scripts/release_performance/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
MAX_CPU_RATIO: float = 1.25
MAX_RSS_RATIO: float = 1.25
MAX_COMPILE_TIME_RATIO: float = 1.15
MAX_EDIT_COMPILE_TIME_RATIO: float = 1.25
MAX_EDIT_COMPILE_TIME_RATIO: float = 1.35
MIN_WALL_REGRESSION_SECONDS: float = 0.5
MIN_CPU_REGRESSION_SECONDS: float = 0.5
MIN_RSS_REGRESSION_BYTES: int = 32 * 1024 * 1024
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/scripts/release_performance/_helpers/test_verdict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,19 +229,19 @@ def test_given_command_minimum_version_when_checking_versions_then_explains_skip
ConfiguredTimeLimitTestCase(
description="a dense one-model edit within the edit limit passes",
command="dense compile (one-model edit)",
wall_ratio=1.232,
wall_ratio=1.289,
expected_regressed=False,
),
ConfiguredTimeLimitTestCase(
description="a one-model edit within the edit limit passes",
command="compile (one-model edit)",
wall_ratio=1.24,
wall_ratio=1.34,
expected_regressed=False,
),
ConfiguredTimeLimitTestCase(
description="a dense one-model edit beyond the edit limit fails",
command="dense compile (one-model edit)",
wall_ratio=1.26,
wall_ratio=1.36,
expected_regressed=True,
),
ConfiguredTimeLimitTestCase(
Expand Down
Loading