Repository navigation
feat(native): plan SQL tests natively behind the preview engine - #1056
Merged
Merged
Conversation
…ursor-window and inspection tests
…h ordering The parity test counts only errors the glue bindings raise, reaches compile_input, planner_input and unresolved-reference errors, and adds a clean seeded variant whose multi-test batches plan. sqb test planning takes the native error messages under preview; the dead None fallback is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQL-test planning sent Python-built JSON to a native planner. Under preview the request now comes straight from the compiled objects.
Changes
sqlbuild-analysis: public request/plan types; typed entry points for batches, chains and error messages. JSON entry points wrap them.plan_compiled_sql_tests,resolve_compiled_sql_test_chainsread compiled objects; Python supplies adapter facts.SQL_TEST_GLUE(preview): compile artifacts,sqb testplanning (now using native error messages) and chains. DeadNonefallback removed; JSON path kept forpython/native.Verification
test --inspectE2E.fast_lineage, differential E2E;make check-ci,make test, hygiene. Earlier:cargo test, clippy/fmt 1.99.0,make compiler-differential(307),-shipped(296).Test expectation changes
plan_native_sql_test_artifactsNone-> artifacts, oneplan_compiled_sql_testscall per batch.compile_input,planner_input,sql_test_reference. Window "raised ≥40" is now a corpus floor (≥108 raised outcomes, either path).sql_test_reference.