Repository navigation
Conversation
kvlonge
force-pushed
the
test/native-fallback-counter
branch
from
October 9, 2026 08:49
d2e5014 to
16150f8
Compare
kvlonge
enabled auto-merge
October 9, 2026 10:41
kvlonge
disabled auto-merge
October 9, 2026 10:42
kvlonge
force-pushed
the
test/native-fallback-counter
branch
from
October 9, 2026 10:42
16150f8 to
a688a67
Compare
kvlonge
enabled auto-merge
October 9, 2026 10:42
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 9, 2026
kvlonge
enabled auto-merge
October 9, 2026 15:43
…en compile outputs Every shipped-stage fallback reports a named site to the compiler differential. One allow-list holds those fallbacks and the preview analysis deferrals with exact counts per corpus, and the CI make targets fail on new, changed or vanished entries. Golden compile outputs cover fixtures, examples, seeds and the failure corpus, and a shared failure-corpus list holds user-facing errors every engine must report with the exact text.
…n with one command
…ate holes Every native stage now reports the work it answered, so a stage switched to Python makes its allow-list entries vanish and fails the gate. The scenario expected-model scan, declaration contexts, the macro memo, effective vars, preview stubs and type normalization count their Python paths. Seed goldens are required inside a recorded range, fixture and example goldens are checked by the shipped differential too, golden inputs trigger the differential, and a failing gate says how to record intended changes.
…il closed on goldens
…er the planning port
kvlonge
force-pushed
the
test/native-fallback-counter
branch
from
October 9, 2026 17:01
a688a67 to
78f5d90
Compare
Contributor
Author
|
Landed together in #1075 to cut merge-queue CI runs; review history stays here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
One gate must prove native did the work; goldens replace the Python oracle. Review found a stage switched off could pass.
Changes
native_fallbacks.toml: exact per-corpus counts of fallbacks, preview deferrals and<stage>.nativeanswers. New, changed or vanished entries fail both CI targets.sql_test_glue/project_assemblyis not a port.seed_range.tomlfails closed; dialect variants are required only for the recorded first seed.engine_error_cases(): exact errors on all engines.type_system(parity test covers it).Entry changes in this update:
macro_call_store.native:store_attachments(302) →served_calls(225), counted when the store serves a call, so the cold-only failure corpus has nonesql_test_glue.planningfallback (14) removed;sql_test_glue.native sql_test_plans(15) addedproject_assembly.nativeanswers and its deferral fallback counted;model_config.python_templatesseed/source fallbacks gone (now native); 1 new goldenLoosening: no goldens for seeds outside the recorded range or ad hoc dialect variants;
<project>/<work>masks. No goldens changed.Verification
test_native_fallback_gate.py): reference scan to Python, analysis session deferring, stages off (incl. all 12 waffle-shop stages),sql_test_glueoff against the committed list, a stale entry. All failnormalize_typeconsults native under preview; fails with the python enginemake compiler-baselines; both CI-flag differentials (324 projects); focused tests;make check-ci;make test; hygiene