Repository navigation
chore: size the 0.156.0 release memory exception to the measured regressions - #1086
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The trusted 0.156.0-vs-0.155.0 release comparison fails only on peak memory, for three commands:
lineage hub downstreamandlineage rollup upstream(80 → 131 MiB, 1.63×) anddense compile (warm cache)(139 → 185 MiB, 1.33×). The same commands are 2.7× and 2.6× faster. The same lineage growth also puts the 3,000-model fresh-processlineageguards at 130–136 MiB against their absolute 128 MiB cap, so they fail on runner noise. The owner approved a one-off exception sized to the failing commands, to be removed after this release so the next one is held to the normal limits against 0.156.0.Changes
lineage column trace,dag --jsonand the one-model edit compile, which now pass at 1.05×, 1.06× and 1.12×.Verification
pytest tests/unit/scripts/release_performance tests/e2e/scripts/release_performance -n auto --dist loadfile: 62 passed.