Repository navigation
test(adapters): give each temporary function case a type its dialect accepts - #1342
Merged
Merged
Conversation
…accepts The shared fixture declared the argument as TEXT for every adapter, so the Databricks expectation pinned DDL that Databricks refuses. Each case now declares a type valid in its dialect, and Databricks renders STRING.
kvlonge
enabled auto-merge (squash)
November 7, 2026 09:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The temporary-function rendering test declared
order_status TEXTfor every adapter. Its Databricks expectation therefore pinnedCREATE OR REPLACE TEMPORARY FUNCTION ... (order_status TEXT), which Databricks refuses withUNSUPPORTED_DATATYPE, becauseTEXTis not a Databricks type.SQLBuild itself was not affected. Function argument types pass through as declared, and the Waffle Shop playground and fixture both declare
STRING. Compiling the fixture for Databricks renders(order_status STRING).Changes
STRINGfor Databricks and BigQuery,TEXTfor Postgres, Snowflake and SQL Server,VARCHARfor DuckDB.(order_status STRING).DuckShop: not applicable. This changes a unit-test input only; no project shape, data value or lifecycle is involved.
Verification
tests/unit/src/sqlbuild/adapter/contract/classes/strict_adapterpasses (14 tests).make check-ci, public-repository scan.