Skip to content

test(adapters): give each temporary function case a type its dialect accepts #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvlonge merged 2 commits into from
Nov 7, 2026
Merged

test(adapters): give each temporary function case a type its dialect accepts #1342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb2e719
test(adapters): give each temporary function case a type its dialect …
kvlonge Nov 7, 2026
0d006e2
Merge branch 'main' into test/databricks-temp-function-type
kvlonge Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/unit/src/sqlbuild/adapter/contract/classes/strict_adapter/_test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,6 @@ class TemporaryFunctionRenderingTestCase:
description: str
adapter: StrictAdapter
language: FunctionLanguage
argument_type: str
return_columns: tuple[tuple[str, str], ...]
expected_temporary_function: TemporaryFunction | None
13 changes: 11 additions & 2 deletions ...src/sqlbuild/adapter/contract/classes/strict_adapter/test_temporary_function_rendering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
description="duckdb copies a sql function into a temporary macro",
adapter=DuckDbAdapter(),
language=FunctionLanguage.SQL,
argument_type="VARCHAR",
return_columns=(),
expected_temporary_function=TemporaryFunction(
target='temp.main."is_completed_order"',
Expand All @@ -36,6 +37,7 @@
description="duckdb copies a table function into a temporary table macro",
adapter=DuckDbAdapter(),
language=FunctionLanguage.SQL,
argument_type="VARCHAR",
return_columns=(("order_id", "INTEGER"),),
expected_temporary_function=TemporaryFunction(
target='temp.main."is_completed_order"',
Expand All @@ -49,13 +51,15 @@
description="duckdb leaves python functions to per-connection registration",
adapter=DuckDbAdapter(),
language=FunctionLanguage.PYTHON,
argument_type="VARCHAR",
return_columns=(),
expected_temporary_function=None,
),
TemporaryFunctionRenderingTestCase(
description="postgres creates the copy in the session pg_temp schema",
adapter=PostgresAdapter(),
language=FunctionLanguage.SQL,
argument_type="TEXT",
return_columns=(),
expected_temporary_function=TemporaryFunction(
target='pg_temp."is_completed_order"',
Expand All @@ -72,6 +76,7 @@
description="snowflake creates a prefixed temporary function in the current schema",
adapter=SnowflakeAdapter(),
language=FunctionLanguage.SQL,
argument_type="TEXT",
return_columns=(),
expected_temporary_function=TemporaryFunction(
target='"__SQB_TEST__IS_COMPLETED_ORDER"',
Expand All @@ -90,19 +95,21 @@
description="bigquery has no session to hold a temporary function",
adapter=BigQueryAdapter(),
language=FunctionLanguage.SQL,
argument_type="STRING",
return_columns=(),
expected_temporary_function=None,
),
TemporaryFunctionRenderingTestCase(
description="databricks creates a prefixed session temporary function",
adapter=DatabricksAdapter(),
language=FunctionLanguage.SQL,
argument_type="STRING",
return_columns=(),
expected_temporary_function=TemporaryFunction(
target="`__sqb_test__is_completed_order`",
statements=(
"CREATE OR REPLACE TEMPORARY FUNCTION "
"`__sqb_test__is_completed_order`(order_status TEXT)\n"
"`__sqb_test__is_completed_order`(order_status STRING)\n"
"RETURNS BOOLEAN\n"
"RETURN order_status = 'completed'",
),
Expand All @@ -112,13 +119,15 @@
description="databricks keeps using built python functions",
adapter=DatabricksAdapter(),
language=FunctionLanguage.PYTHON,
argument_type="STRING",
return_columns=(),
expected_temporary_function=None,
),
TemporaryFunctionRenderingTestCase(
description="sql server keeps using the built function",
adapter=SqlServerAdapter(),
language=FunctionLanguage.SQL,
argument_type="TEXT",
return_columns=(),
expected_temporary_function=None,
),
Expand All @@ -132,7 +141,7 @@ def test_given_project_function_when_rendering_temporary_copy_then_adapter_retur
name="is_completed_order",
definition=FunctionDefinition(
destination="analytics.is_completed_order",
arguments=(FunctionArgument(name="order_status", type="TEXT"),),
arguments=(FunctionArgument(name="order_status", type=test_case.argument_type),),
returns="BOOLEAN",
body_sql="order_status = 'completed'",
return_columns=tuple(
Expand Down
Loading