Repository navigation
feat: format BigQuery, PostgreSQL and T-SQL with SQLQuack - #42
Merged
Merged
Conversation
Pin SQLQuack at main 33e43849, whose SQL Server parser reports where each statement was written and reads procedures, and whose formatter lays out BigQuery and PostgreSQL. - bigquery, postgres and postgresql files are formatted; their corpora match SQLQuack's, with its departures copied. - tsql, mssql and sqlserver files are formatted; format splits a T-SQL file at the statements SQL Server's parser reads, so a batch written without semicolons comes out one statement apart. - Facts ask whether a dialect parses with SELECT 1, not empty SQL, which the Databricks parser refuses; Databricks files were failing format. - The configuration page says which dialects each command reads.
Deploying sqlclean with
|
| Latest commit: |
54e5c96
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ad82ecb7.sqlclean.pages.dev |
| Branch Preview URL: | https://feat-tsql-bigquery-postgres.sqlclean.pages.dev |
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack main 33e43849 formats BigQuery and PostgreSQL, and its SQL Server parser reads procedures and reports where each statement was written. SQLClean 0.5.0 formats only DuckDB and Snowflake.
Changes
sqlquack-syntax-sqlserver.bigquery,postgres/postgresqlandtsql/mssql/sqlserver. Corpus tests expect SQLQuack's counts, with its departures copied.formatsplits T-SQL at the statements SQL Server's parser reads, so a batch without semicolons comes out one statement apart.SELECT 1: the Databricks parser refuses empty SQL, which made every Databricks file failformat.Verification
make check-cipasses (fensu 0 faults, clippy-D warnings).cargo test --all: 40 passed, 1 ignored, plus 8. Corpus formatted/refused: Snowflake 426/9, DuckDB 189/0, BigQuery 161/7, PostgreSQL 124/13, T-SQL 52/23.pytest: 72 passed, with new end-to-end cases for T-SQL batches, procedures, aliases, BigQuery, PostgreSQL and Databricks.cargo treeor Cargo.lock.