Repository navigation
fix(playground): repeated result names as the statement returns them, and whole raised messages - #137
Merged
Merged
Conversation
…aised messages The Run stage reads each column's values by position and labels the header with DESCRIBE's names, so `SELECT order_id, order_id` shows two ORDER_ID columns with their own values instead of the wrapper's ORDER_ID_1, or one column when rows were read as objects. run_failure ends a raised message at the last quote on its line, the one DuckDB closes the tagged text with, so messages holding a quote, such as "Can't parse the text as date with the format", read back whole.
kvlonge
added a commit
that referenced
this pull request
Nov 6, 2026
Contributor
Author
|
Gate passed on the exact head 1362af4: #137 at 17beff1 (auditor record 5ca1484), merged with main 99e4ab3.
GitHub Actions can't run because of the account billing block, so this local gate is the check for this landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #132, stacked on it: base
feat/playground-sample-schemaat 8f8b12e, one commit. The coordinator queues it after #135 and ahead of D315.1. Repeated result names (D335). The Run stage wraps each translation in
SELECT COLUMNS(*)::VARCHAR FROM (<sql>) AS result. DuckDB renames a repeated name inside a subquery, soSELECT order_id, order_idcame back as ORDER_ID, ORDER_ID_1. Reading rows withrow.toJSON()would also collapse duplicate keys into a single column. The fix:DESCRIBE <sql>returns. DESCRIBE only binds the statement, it doesn't run it, and it keeps top-level names exactly as DuckDB 2.0 and Snowflake return them.2. "Can't" cut (#132 audit note).
run_failureused to end a raised message at the first quote after the tag. So "Can't parse the text as date with the format" (100097/100096) and the TIME format message read back as "Can". It now ends at the last quote on the line, which is the one DuckDB closes the tagged text with. Native DuckDB 2.0.0 prints the quote unescaped:Could not convert string 'sqlquack:100097#…: Can't parse … format' to INT32.Tests (
npm run test:engine, 12 pass):TO_DATE(note, 'YYYY-MM-DD')under the repository policy reads back with errno 100097, the full message, and the raise ID pointing at the TO_DATE span.fmt, fensu and the hygiene scan are clean.