Repository navigation
fix(syntax): keep the parse in parse_strict so the instruction guard counts it - #189
Merged
Merged
Conversation
…counts it parse_strict only called strict_statements, so it compiled to a single jump, and the release pull request's CI build counted nothing in it: callgrind's collection starts at parse_strict's entry. strict_statements is now inlined into it, its one caller, and parse_strict is never inlined into a caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release pull request's CI fails the instruction-count guard ("callgrind counted nothing in parse_strict"), which blocks the release.
parse_strictonly calledstrict_statements, so it compiled to a single jump, and on the release build callgrind never collected from it.Changes
strict_statementsis inlined intoparse_strict, its one caller, andparse_strictis never inlined into a caller, so the parse runs inside the function the guard counts from. The count is unchanged.Verification
parse_strictholds the parse body (it opens with a full prologue, and nostrict_statementssymbol is left);make instruction-countsgives 253,172,343 parse instructions against the 253,081,114 baseline.make check-cipasses.