Skip to content

fix(syntax): keep the parse in parse_strict so the instruction guard counts it #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvlonge merged 1 commit into from
Nov 12, 2026
Merged

fix(syntax): keep the parse in parse_strict so the instruction guard counts it #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/sqlquack-syntax-snowflake/src/modes/main/parse_strict.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ use sqlquack_syntax::expressions::tree::models::Expression;
use sqlquack_syntax::guard::models::ParseOptions;
use sqlquack_syntax::tokens::models::Dialect;

/// The statements of `sql`, refusing on any parse error or any byte no token covers.
/// The statements of `sql`, refusing on any parse error or uncovered byte; the instruction guard's entry.
#[inline(never)]
pub fn parse_strict(
sql: &str,
dialect: Dialect,
Expand Down
3 changes: 2 additions & 1 deletion crates/sqlquack-syntax-snowflake/src/parser/main/strict_statements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ use sqlquack_syntax::tokens::models::{CallMode, Dialect};
use crate::modes::errors::StrictFailure;
use crate::parser::_helpers::support::dialects::dialect_type;

/// The statements of `sql`, with coverage checked over the tokens the parse itself read.
/// The statements of `sql`, coverage checked over the tokens read; inlined so `parse_strict` holds it.
#[inline(always)]
pub(crate) fn strict_statements(
sql: &str,
dialect: Dialect,
Expand Down
Loading