Repository navigation
Join changed cases to Snowflake's receipts in the coverage diff, whatever they expect - #58
Merged
Merged
Conversation
… whatever it expects The snapshot took Snowflake's verdict from a case's checked phase, which is none for every observe case, so a receipted observe case the parser stopped accepting never reached the diff (#55's three regressions, audit 38bed22). Each case result now carries what Snowflake's parser did, by every syntax receipt of its SQL, setup and session whatever the case id: parsed when all stopped after parsing with an errno other than 1003, refused when all are a positioned 1003 or a 921, and nothing for a positionless 1003 or receipts that disagree. The diff fails on a parsed case the parser now rejects, as before, and also on a refused case it now accepts.
Contributor
Author
|
Gate (D94) and landing record.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage diff's "Snowflake-parsed cases the parser now rejects" line reported 0 on #55, although #55 changed the verdict of four receipted observe cases (audit 38bed22). The snapshot took Snowflake's verdict from each case's checked phase, which the check leaves empty for every
observecase, so those cases never reached the diff.Each case result now records what Snowflake's parser did, joined by the case's SQL, setup and session hashes to every syntax receipt, whatever the case id or expectation:
difffails on a parsed case the parser now rejects (as before) and, new, on a refused case it now accepts.Check: rebuilt at 497ad27 and 77e10ee with this change, the diff of #55 on catalogue c9ce0ff plus evidence 1c56796 now reports exactly the audit's four rows:
database-role-clone.k2f294878f7ba,create-stream-clone.k6bedaffe7427,create-database-role.k9de9327a97cecreate-database.k3c0dc0ce5fe8The new test
given_receipted_cases_of_any_expectation_when_the_parser_changes_then_the_diff_flags_contradictionscovers those shapes plus controls (positionless 1003, disagreeing receipts, unchanged parser), and fails with the join removed.