Skip to content

bench: generate arrays with NaN values - #14402

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
ujjwalv01:fix-missing-native-benchmarks-dnanmean
Aug 19, 2026
Merged

bench: generate arrays with NaN values#14402
kgryte merged 2 commits into
stdlib-js:developfrom
ujjwalv01:fix-missing-native-benchmarks-dnanmean

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • Updates the benchmark.native.js implementations for @stdlib/stats/base/ndarray/dnanmean, dnanmeanors, and dnanmeanwd.
  • Ensures the native benchmarks correctly track their respective benchmark.js implementations by properly injecting NaN values into the test arrays using bernoulli and fillBy.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Follow-up to previous reviews.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 marked this pull request as ready for review August 19, 2026 07:35
@ujjwalv01
ujjwalv01 requested a review from a team August 19, 2026 07:35
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Aug 19, 2026
@stdlib-bot

stdlib-bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/dnanmean $\\color{green}176/176$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}176/176$
$\\color{green}+100.00\\%$
stats/base/ndarray/dnanmeanors $\\color{green}176/176$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}176/176$
$\\color{green}+100.00\\%$
stats/base/ndarray/dnanmeanwd $\\color{green}176/176$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}176/176$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. review: 5 and removed Needs Review A pull request which needs code review. labels Aug 19, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the follow-up, @ujjwalv01!

@kgryte kgryte changed the title fix: update native benchmark scripts for dnanmean, dnanmeanors, and dnanmeanwd bench: generate arrays with NaN values Aug 19, 2026
@kgryte
kgryte merged commit 82ee27d into stdlib-js:develop Aug 19, 2026
95 checks passed
@Planeshifter Planeshifter mentioned this pull request Aug 19, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants