Repository navigation
Fix KL divergence clipping for integer regression inputs - #1348
Merged
Merged
Conversation
Test CoverageTotal: 73.30% (19606 / 26747 lines)
|
solarsys
approved these changes
Oct 30, 2026
solarsys
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the diff and ran the full core suite locally with this PR applied; no new failures. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor: Pema Sangpo Lama (@pemalama12)
Contribution Type: Bug fix with regression tests
Description: Integer arrays containing zeros produce
NaNfor KL divergence: assigning the1e-6floor into an integer copy truncates it to zero. Usenp.clipto create copies that can represent the floor. This also fixes the time-series wrapper while preserving the inputs and MSE/MAE values.Files to Review:
pyhealth/metrics/regression.py: clipping fix.tests/core/test_regression_integer_kl.py: signed/unsigned integers, mixed dtypes, all-zero arrays, float compatibility, metric order, unchanged inputs, and the time-series wrapper.Validation: 15 integer cases fail on master; all 5 new tests and 10 existing time-series tests pass with the fix. Ruff passes for the new tests, and
tools/check_pr_rules.pypasses.Manual reproduction:
Expected: finite KL divergence ≈
13.81548, MSE1.0, MAE1.0. Master returnsNaNfor KL.Separate from #1324's docstring and shape-check changes.