Repository navigation
docs: fix docstring examples for RandomBaseline and CrhEnsemble - #1349
Merged
solarsys merged 1 commit intoOct 30, 2026
Merged
Conversation
RandomBaseline's example imported a nonexistent `Random`; use the exported `RandomBaseline`. CrhEnsemble's example imported nonexistent `GradientShap` and `Saliency`; use the exported IntegratedGradients, DeepLift and LimeExplainer, matching the other ensemble examples. Follow-up to sunlabuiuc#1341; addresses sunlabuiuc#324 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Test CoverageTotal: 73.26% (19597 / 26749 lines)
|
solarsys
approved these changes
Oct 30, 2026
solarsys
left a comment
solarsys
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the diff and ran the full core suite locally with this PR applied; no new failures. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor: Joshua Sebastian (joshb-code)
Contribution Type: Documentation (docstring fix)
Description: Follow-up to #1341, addressing the review suggestion. Two docstring examples referenced names that don't exist and now render on the interpret API pages:
RandomBaseline: imported a nonexistentRandom; now uses the exportedRandomBaseline.CrhEnsemble: imported nonexistentGradientShapandSaliency; now usesIntegratedGradients,DeepLiftandLimeExplainer, matching the other ensemble examples.Docstring-only, 4 lines changed. I verified the example imports resolve; I did not run the full examples end to end. Ruff reports no issues on the changed lines. Addresses #324.
Files to Review:
pyhealth/interpret/methods/baseline.py- RandomBaseline docstring examplepyhealth/interpret/methods/ensemble_crh.py- CrhEnsemble docstring example🤖 Generated with Claude Code