Repository navigation
fix(repository): require github provider >= 6.12 - #53
Merged
Merged
Conversation
Terraform Integration
✅ All 1 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
modules/repository/versions.tfdeclaresintegrations/github >= 6.2, but the module needs>= 6.12:modules/repository/main.tf:120usesgithub_repository_vulnerability_alerts, which first appears in provider 6.12.0 (added in fix(repository): migratevulnerability_alertsto dedicated resource #34).modules/repository-environmentmodule (called frommodules/repository/actions.tf) setsvalueongithub_actions_environment_secret, which also first appears in 6.12.0 (added in fix(repository-environment): replace deprecatedplaintext_valuewithvalue#33).terraform validate/planwithThe provider integrations/github does not support resource type "github_repository_vulnerability_alerts".References
vulnerability_alertsto dedicated resource #34plaintext_valuewithvalue#33Description
modules/repository/versions.tf:>= 6.2→>= 6.12modules/repository/README.md: requirements/providers table regenerated withterraform-docs🚨 To Reviewers
repository-environmentmodule's own constraint is fixed in a separate PR (fix(repository-environment): require github provider >= 6.12 #54); this PR does not depend on it.terraform providers schema -json):github_repository_vulnerability_alertsis absent in 6.2.0 and 6.11.0 and present in 6.12.0.origin/maincopy with the provider pinned to= 6.11.0:terraform validatefails (does not support resource type "github_repository_vulnerability_alerts",An argument named "value" is not expected here). Pinned to= 6.12.0: valid.terraform fmt -check -recursiveclean;terraform init -backend=false+terraform validateinmodules/repositorysucceed (resolved 6.13.0; only the existingautocreate_branchdeprecation warning).Worktree:
~/.git-worktrees/tedilabs/terraform-github-modules/repository-min-github-provider/