Repository navigation
fix(repository-environment): require github provider >= 6.12 - #54
Merged
Merged
Conversation
Terraform Integration
✅ All 1 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
modules/repository-environment/versions.tfdeclaresintegrations/github >= 6.11, butmodules/repository-environment/main.tfsetsvalueongithub_actions_environment_secretand lists it inignore_changes(added in fix(repository-environment): replace deprecatedplaintext_valuewithvalue#33). Thevalue/value_encryptedarguments first appear in provider 6.12.0; the 6.11.0 schema only hasplaintext_value/encrypted_value.[6.11, 6.12), the constraint is satisfied butterraform validate/planfails withAn argument named "value" is not expected here.References
plaintext_valuewithvalue#33Description
modules/repository-environment/versions.tf:>= 6.11→>= 6.12modules/repository-environment/README.md: requirements/providers table regenerated withterraform-docs🚨 To Reviewers
repositorymodule, which calls this one, is bumped in a separate PR (fix(repository): require github provider >= 6.12 #53).terraform providers schema -json):github_actions_environment_secrethas novalueattribute in 6.11.0; it is present in 6.12.0.origin/maincopy with the provider pinned to= 6.11.0:terraform validatefails (An argument named "value" is not expected here). Pinned to= 6.12.0: valid.terraform fmt -check -recursiveclean;terraform init -backend=false+terraform validateinmodules/repository-environmentsucceed (resolved 6.13.0).Worktree:
~/.git-worktrees/tedilabs/terraform-github-modules/repository-environment-min-github-provider/