Skip to content

fix(webapp): use native selectable row controls - #4700

Merged
carderne merged 4 commits into
fix/webapp-time-filter-semantics-tri-13381from
fix/webapp-selectable-row-semantics-tri-13381
Aug 19, 2026
Merged

fix(webapp): use native selectable row controls#4700
carderne merged 4 commits into
fix/webapp-time-filter-semantics-tri-13381from
fix/webapp-selectable-row-semantics-tri-13381

Conversation

@carderne

@carderne carderne commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Use native controls for sortable columns and selectable prompt versions.

Table headers keep filter actions separate from sort buttons, prompt version rows expose pressed state, and a redundant deployment click interceptor is removed.

Base: #4699

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cd63c4e2-fe61-49cb-8afa-c6d9e694e38e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch from c11c668 to ef371d9 Compare August 19, 2026 11:01
@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 61469ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ef371d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@carderne
carderne marked this pull request as ready for review August 19, 2026 11:23
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch from ef371d9 to 43fff42 Compare August 19, 2026 11:48
@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch from 43fff42 to 7901af7 Compare August 19, 2026 11:49
@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch from 7901af7 to 2b44421 Compare August 19, 2026 11:51
@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch 2 times, most recently from 50758ec to c0cb2af Compare August 19, 2026 11:56
@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch from 1de4d9c to 99f768a Compare August 19, 2026 12:38
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch from 99f768a to 398a6ce Compare August 19, 2026 13:07
devin-ai-integration[bot]

This comment was marked as resolved.

@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch from 623ef84 to 941e4a2 Compare August 19, 2026 13:36
@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch from bbfc891 to d9a5204 Compare August 19, 2026 14:04
Clicking the info-icon tooltip in a sortable column header still
toggled the column sort because the click bubbled up to the header's
click handler, unlike the dedicated sort and filter buttons, which
already stop propagation. Stop the click from bubbling past the
tooltip so hovering or clicking the info icon no longer changes the
sort order.
@carderne
carderne force-pushed the fix/webapp-selectable-row-semantics-tri-13381 branch from d9a5204 to 61469ae Compare August 19, 2026 14:54
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@61469ae

trigger.dev

npm i https://pkg.pr.new/trigger.dev@61469ae

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@61469ae

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@61469ae

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@61469ae

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@61469ae

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@61469ae

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@61469ae

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@61469ae

commit: 61469ae

@carderne
carderne merged commit 5ae2471 into main Aug 19, 2026
39 checks passed
@carderne
carderne deleted the fix/webapp-selectable-row-semantics-tri-13381 branch August 19, 2026 15:36
carderne added a commit that referenced this pull request Aug 19, 2026
## Summary

Move tree selection onto semantic tree items and use native expansion
buttons.

Dashboard and story tree rows now share mouse and keyboard selection
through `getNodeProps`. Expand and collapse affordances are named
buttons instead of clickable layout elements.

Base: [#4700](#4700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants