fix(webapp): align tree mouse and keyboard interactions - #4701
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f91b2b6 to
98f0718
Compare
98f0718 to
0c04fad
Compare
01dd835 to
fb368fe
Compare
fb368fe to
9aa9cbb
Compare
8797fd4 to
a3d702a
Compare
2877bf2 to
3abdf38
Compare
3abdf38 to
e4ebd46
Compare
2936415 to
beb6bc5
Compare
beb6bc5 to
4779d56
Compare
The task-arrow button used a disabled attribute for leaf rows, which also blocks the click event entirely, so alt-clicking a leaf's arrow no longer expanded or collapsed every row at that depth. Guard the per-node toggle instead and keep the button clickable, and mark it aria-disabled for styling. Also pass preventScroll to the post-toggle focus() call so it can't fight the just-completed scrollToNode.
4779d56 to
b439186
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
## Summary Enable keyboard-event and static-element interaction safeguards across the dashboard. Earlier stack changes move actionable behavior to native controls. This final enforcement keeps narrowly documented exceptions for focus forwarding, scoped Escape handling, CodeMirror focus, and pointer-driven table column resizing. `jsx-a11y/no-autofocus` remains disabled. Base: [#4701](#4701)
Summary
Move tree selection onto semantic tree items and use native expansion buttons.
Dashboard and story tree rows now share mouse and keyboard selection through
getNodeProps. Expand and collapse affordances are named buttons instead of clickable layout elements.Base: #4700