Skip to content

fix(build): support direct minimal versions - #11330

Draft
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:minver
Draft

xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:minver

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Mar 14, 2026 •

Copy link
Copy Markdown
Collaborator

Fix the build with Cargo’s direct-minimal-versions feature.

cargo minimal-versions check --quiet --workspace --all-targets --all-features --direct --workspace-behavior=cargo --target aarch64-apple-darwin

Closes #14929

@xtqqczze xtqqczze changed the title Fix the build with -Zdirect-minimal-versions deps: update for direct-minimal-versions Mar 14, 2026
@xtqqczze
xtqqczze marked this pull request as ready for review April 9, 2026 16:52
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)

@xtqqczze
xtqqczze force-pushed the minver branch 2 times, most recently from 4764b01 to bf28483 Compare April 10, 2026 13:50
@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/head/head-write-error. tests/head/head-write-error is passing on 'main'. Maybe you have to rebase?

@xtqqczze

This comment was marked as outdated.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.

@xtqqczze

This comment was marked as outdated.

@xtqqczze

This comment was marked as outdated.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)

@github-actions

github-actions Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/df/df-output is no longer failing!

@codspeed

codspeed Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 4.72%

⚠️ 121 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 1 benchmark has no flamegraph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 400 untouched benchmarks
⏩ 70 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ ⚠️ CPU Simulation du_deep_tree[(100, 3)] 1.9 ms 1.9 ms +4.72%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:minver (2c52b83) with main (ae34722)2

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (198c615) during the generation of this report, so ae34722 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze
xtqqczze force-pushed the minver branch 2 times, most recently from 64b0131 to 38eb595 Compare August 30, 2026 17:31
@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 152.18 MB (+1004 KB, +0.65%)

Significant per-binary changes:
  comm     1.12 MB ->    2.33 MB  (+1.21 MB, +107.29%)

@xtqqczze
xtqqczze force-pushed the minver branch 6 times, most recently from 5265189 to 293409e Compare September 15, 2026 03:17
@xtqqczze xtqqczze changed the title deps: update for direct-minimal-versions fix(build): support -Zdirect-minimal-versions Sep 15, 2026
@xtqqczze
xtqqczze force-pushed the minver branch 5 times, most recently from c2bc9aa to 3704b07 Compare September 16, 2026 14:22
@xtqqczze xtqqczze changed the title fix(build): support -Zdirect-minimal-versions fix(build): support direct minimal versions Sep 16, 2026
@xtqqczze
xtqqczze marked this pull request as draft September 19, 2026 22:40
@xtqqczze
xtqqczze marked this pull request as ready for review September 20, 2026 16:58
unset CARGO_FEATURES_OPTION
if [ -n "${{ matrix.job.features }}" ]; then CARGO_FEATURES_OPTION='--features "${{ matrix.job.features }}"' ; fi
outputs CARGO_FEATURES_OPTION
- name: Generate minimal lockfile

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right place for this step

@xtqqczze
xtqqczze marked this pull request as draft September 20, 2026 16:59
@xtqqczze
xtqqczze force-pushed the minver branch 3 times, most recently from 646d453 to 5aaf4fe Compare September 26, 2026 14:03
@xtqqczze xtqqczze self-assigned this Sep 28, 2026
@xtqqczze
xtqqczze force-pushed the minver branch 2 times, most recently from 8ab99e6 to c1067d0 Compare October 18, 2026 03:12
Fix the build with Cargo’s [`direct-minimal-versions`](https://doc.rust-lang.org/cargo/reference/unstable.html#direct-minimal-versions) feature.

```sh
cargo minimal-versions check -q --workspace --all-targets --all-features --direct --workspace-behavior=cargo --target aarch64-apple-darwin
```

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: support direct minimal versions

1 participant