[limadog9]

Define the BSD configuration alias for integration tests and use it in test_stty.rs instead of repeated platform lists.

Closes #15423.

[xtqqczze]

Suggested change

// Configuration aliases are crate-local; integration tests need this too.

no need to narrate the diff in comments

[oech3]

Is this applied for uu_*? Or coreutils and test only?

[xtqqczze]

Is this applied for uu_*? Or coreutils and test only?

These changes affect coreutils package only (including tests/by-util).

[oech3]

Sad...

[xtqqczze]

Unfortunately, we have to define cfg aliases in each package, at least based on my conclusions in #11016.

[limadog9]

If we want the full buffet, could we put the alias definitions in a shared build helper that each package’s build.rs calls? Cargo would still need the hookup in each package, but at least we’d only cook the BSD list once

[xtqqczze]

could we put the alias definitions in a shared build helper that each package’s build.rs calls?

We already tried and failed to make that work: #11016 (comment)

[limadog9]

Could we reuse uucore_procs for a small platform_cfg_aliases!() macro called from each build script? It could supply the shared platform-only aliases and accept package-specific aliases as input. That would preserve the existing cfg checks without another helper crate or cross-package includes. Each package would still need to opt in, but perhaps we could try it just for root + stty first?

[xtqqczze]

We found the right approach for a shared build helper: #15634.

[codspeed]

Merging this PR will degrade performance by 8.45%

⚠️ 123 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

• du_wide_tree[(5000, 500)]
• dd_copy_partial
• sort_unique_utf8_locale
• du_all_wide_tree[(5000, 500)]
• cksum_raw_output
• cksum_sysv
• cksum_default
• cksum_multiple_files
• cksum_crc
• factor_multiple_u64s[2]
• …and 113 more

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

• sort_dictionary_order[500000]

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 399 untouched benchmarks
⏩ 70 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌	Simulation	factor_three_39_bit_primes	593.6 ms	752.6 ms	-21.12%
⚡	Simulation	factor_five_38_bit_primes	1.9 s	1.8 s	+6.25%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing limadog9:fix/stty-test-bsd-alias (9ee6a9d) with main (2e28cc3)}

Footnotes

1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[xtqqczze]

Superseded by #15634.