Repository navigation
chore(ui): remove the local browser E2E - #870
Merged
Merged
Conversation
Teakowa
approved these changes
Oct 20, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
Approve (round 1).
Checks
- The removal is complete.
ui/scripts/e2e.mjs, thetest:e2escript, theui/README.mdsection, and theui-view.wsfixture are gone. On the PR head,git grepfordata-e2e,ui-view,test:e2eande2e.mjsfinds nothing outsideCHANGELOG.md, which is release history and correctly untouched..githubonmainhas no E2E reference. - Scope: nine files, 22 added and 633 removed lines. The
App.svelte,Dialogs.svelteandRuleView.sveltechanges only drop thedata-e2eattributes. I found no other change in them.git diff --checkis clean. - Local checks on the PR head:
npm ci,npm run check(127 files, 0 errors, 0 warnings),npm test(18 of 18),npm run buildandnpm run check:size(21.5 KiB gzipped, budget 100) all pass. CIUIis green.Rust (stable) / QualityandProduct integrationwere still pending at review time. - The commit message and PR body say
Refs #862and carry noFixes. This is correct, because the PR removes the flaky test and does not close the issue.
Non-blocking
docs/adr/0032-structured-editor-form-factor.mdloses an acceptance sentence for item 10 (an end-to-end edit test). The PR body says the owner decided this, and it flags a possible future decision for the editing layer. Please link that owner decision, or a follow-up issue, from the ADR or the PR so the ADR does not silently lose a requirement.- Check that #862 ends in the right state: with the E2E deleted, the issue's
openRule(4, 'after')timeout can no longer occur. Close it with a note, or leave it, but record the choice.
e54-bot
enabled auto-merge (squash)
October 20, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the local UI browser E2E. The owner decided it is not trusted and has low value; it left CI in #865 and must not gate merges.
Refs #862
Removed
ui/scripts/e2e.mjsand thetest:e2escript inui/package.jsonui/README.mddata-e2eattributes inui/src/App.svelte,ui/src/lib/Dialogs.svelte,ui/src/lib/RuleView.svelte(used only by the script)tests/fixtures/workshop/synthetic/ui-view.ws(used only by the script)docs/LESSONS.md: one sentence that pointed ate2e.mjsnow says the E2E was deleted; history keptNo dependencies or ignore rules existed for it (the script used no browser driver).
Verified
npm run check,npm test(18 pass),npm run build,npm run check:size,actionlint,git diff --check; grep shows no remaining reference. CI UI job unchanged.Follow-up
None needed. The
wright uiserver is covered by its own Rust tests (crates/wright-cli/tests/ui.rs), so no product code existed only for the E2E. ADR-0032 may still deserve an owner decision on whether a future editing layer needs its own end-to-end check.