Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/LESSONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Short review queue of reusable failure classes from merged Wright work. Each ent
### A check waits for the state it asserts on, not a fixed window
- **Rule:** An end-to-end check must poll for the concrete state it asserts — the loaded rule body, the flushed render; a fixed wall-clock window fails on slow runners and unrelated PRs.
- **Why:** The UI E2E read rendered statements before the selected rule's content flushed and bounded each check by a fixed 15s window, so it flaked on `main` and unrelated PRs until the job left CI.
- **Prevention home:** the wait-for-state checks landed in #863's `e2e.mjs`; the job runs locally only (#865) until it is deterministic.
- **Prevention home:** the wait-for-state checks landed in #863; the UI browser E2E was removed from CI (#865) and then deleted.
- **Incidents:** [wright#829](https://github.com/wrightkit/wright/pull/829) E2E reported in [wright#862](https://github.com/wrightkit/wright/issues/862), fixed by [wright#863](https://github.com/wrightkit/wright/pull/863), CI gate removed by [wright#865](https://github.com/wrightkit/wright/pull/865) — observed 2026-10-20

### A version bump re-audits the resolved dependency footprint
Expand Down
1 change: 0 additions & 1 deletion docs/adr/0032-structured-editor-form-factor.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ Goal principle 1 makes `wright` the product the user runs. The goal keeps a gene

10. **Verification.**
- CI gains one UI job: `svelte-check`, unit tests, the production build, and a size budget of 100 KB gzipped for JavaScript and CSS together. A larger bundle fails the job.
- An end-to-end test drives `wright ui` on a committed raw Workshop fixture in a headless browser. The test opens a rule, edits a statement through the form, submits it, and checks that the file on disk equals the edit `editStatements` validated.

11. **Delivery in layers.**
- The first release is read-only: the rule list, the event row, and coloured conditions and actions.
Expand Down
83 changes: 0 additions & 83 deletions tests/fixtures/workshop/synthetic/ui-view.ws

This file was deleted.

15 changes: 0 additions & 15 deletions ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,9 @@ npm run dev # dev server
npm run build # production build -> dist/ (ignored, never committed)
npm run check # svelte-check + tsc
npm test # vitest unit tests
npm run test:e2e # browser E2E: wright ui + headless Chromium-family
npm run check:size # dist/ JS+CSS must be < 100 KiB gzipped (fails over)
```

`test:e2e` is a local check and does not run in CI. It builds nothing itself: it needs a `wright` binary built with
`--features ui` after `npm run build` (debug builds embed `dist/` at
compile time), and a Chromium-family browser. Overrides:

```sh
WRIGHT_BIN=target/debug/wright # binary under test
WRIGHT_UI_BROWSER=brave # executable path or its name on PATH
E2E_TRACE=1 # echo browser stderr while diagnosing
```

The script spawns `wright ui --no-open tests/fixtures/workshop/synthetic/ui-view.ws`,
launches the browser headless, and drives the real DOM over the DevTools
protocol — no driver dependency.

## Generated types

`src/lib/types/generated/` is generated from the committed schemas — never edited by
Expand Down
1 change: 0 additions & 1 deletion ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"preview": "vite preview",
"check": "svelte-check --tsconfig ./tsconfig.app.json && tsc -p tsconfig.node.json",
"test": "vitest run",
"test:e2e": "node scripts/e2e.mjs",
"generate-types": "node scripts/generate-types.mjs",
"check-types": "node scripts/generate-types.mjs --check",
"check:size": "node scripts/check-bundle-size.mjs"
Expand Down
Loading
Loading