Repository navigation
feat(notation): Orbit64 V2 tokens for sizes 2 to 15, remove V1 - #69
Conversation
12f3814 to
2e7e48a
Compare
|
Review: FINDINGS head=12f3814980abedcd6fb1e5d40d94d86d4ec020bd patch-id=a2add69d8bb330ef671df7b997714ef8a3cc852b pr=69 |
8e0d1c0 to
ef5a73a
Compare
|
Review: CLEAR head=ef5a73afc6d65e040aa04dd469a1230b53af90a2 patch-id=7ca782456b54124abddab83f5dafb40ab832e10e pr=69 |
Orbit64Token.res writes and reads the V2 color framed token through the facelet bridge. Tokens of sizes 2, 3, 4, 6 and 7 equal the V1 strings. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The notation card writes a token for every size, the typed-input reader decodes V2 tokens, and the texts say 2×2–15×15. The UI-layer tests round-trip token and facelets for every size. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
V2 is the only state token format. The coordinate arithmetic the V2 codec shares moves to Orbit64Coords.res; the V1 token code, its slot tables, its TypeScript entry points and its test are removed. The V1 reference vectors stay as V2 input vectors. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Typed facelets show a token of the size's width, and the token read back gives the same facelets, without page errors. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The test lives under test/cube/notation. A picture-model token is refused and a token with surrounding spaces is read. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ef5a73a to
d5d500f
Compare
|
Review: CLEAR head=d5d500ff0fb098592ebe87fa583abb4deb3283ad patch-id=7ca782456b54124abddab83f5dafb40ab832e10e pr=69 |
The app token is the V2 codec since #69, so the property no longer needs the 2 to 7 generator of the removed V1 codec. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The app token is the V2 codec since #69, so the property no longer needs the 2 to 7 generator of the removed V1 codec. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
CubeAssembler writes and reads Orbit64 V2 state tokens for cube sizes 2 to 15. The V1 codec is removed (owner decision 2026-11-18).
Changes:
Orbit64Token.res: V2 color framed token over the facelet bridge (Orbit64V2Facelets). Tokens of sizes 2, 3, 4, 6 and 7 equal the V1 strings.Orbit64.res(i),Orbit64Tables.res,orbit64.ts,orbit64LargeTables.ts,orbit64.test.ts. Shared coordinate arithmetic moved toOrbit64Coords.res. The Flix V1 vector files stay as V2 input vectors.Known consequence: V2 reads V1 tokens of lengths 5, 12, 27, 66 and 90 as color framed entries at offset 0, but refuses the 43-character V1 5x5 tokens (
test/cube/notation/orbit64V2.test.ts). A stored or typed V1 5x5 token no longer works; the input field names this in its error.Tests:
test/cube/notation/orbit64Token.test.ts(token and facelets round trip for 2..15, framed color entry per size, V1 vectors unchanged, 43-character and picture tokens refused);e2e/notation.spec.tstypes 8x8 to 15x15 facelets, checks the token width, reads it back, no page errors.Mutations killed: size 8 rejected, V1 decode path, pose Canonical, color guard removed, trim removed,
size <= 7in the notation card (e2e).Results: typecheck, lint, format:check, typos, build pass; e2e
notation.spec.tsandpreferences.spec.ts16/16; CI green on this head. vitest 1552 pass / 47 fail, the 47 LFS photo failures of #67.Out of scope: profiles and cookies,
GuidedCaptureSetup.res,NetImage.res, schemas and fingerprint, wider docs.Blocker: none.
🤖 Generated with Claude Code