Skip to content

feat(notation): Orbit64 V2 tokens for sizes 2 to 15, remove V1 - #69

Merged
wstein merged 6 commits into
mainfrom
feat/app-orbit64-v2-only
Nov 18, 2026
Merged

wstein merged 6 commits into
mainfrom
feat/app-orbit64-v2-only

Conversation

@wstein

@wstein wstein commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

CubeAssembler writes and reads Orbit64 V2 state tokens for cube sizes 2 to 15. The V1 codec is removed (owner decision 2026-11-18).

Changes:

  • Orbit64Token.res: V2 color framed token over the facelet bridge (Orbit64V2Facelets). Tokens of sizes 2, 3, 4, 6 and 7 equal the V1 strings.
  • The notation card shows and copies a token for every size; typed input and paste decode V2 color tokens (picture-model tokens are refused). Texts say 2×2–15×15.
  • Removed: Orbit64.res(i), Orbit64Tables.res, orbit64.ts, orbit64LargeTables.ts, orbit64.test.ts. Shared coordinate arithmetic moved to Orbit64Coords.res. The Flix V1 vector files stay as V2 input vectors.

Known consequence: V2 reads V1 tokens of lengths 5, 12, 27, 66 and 90 as color framed entries at offset 0, but refuses the 43-character V1 5x5 tokens (test/cube/notation/orbit64V2.test.ts). A stored or typed V1 5x5 token no longer works; the input field names this in its error.

Tests: test/cube/notation/orbit64Token.test.ts (token and facelets round trip for 2..15, framed color entry per size, V1 vectors unchanged, 43-character and picture tokens refused); e2e/notation.spec.ts types 8x8 to 15x15 facelets, checks the token width, reads it back, no page errors.
Mutations killed: size 8 rejected, V1 decode path, pose Canonical, color guard removed, trim removed, size <= 7 in the notation card (e2e).
Results: typecheck, lint, format:check, typos, build pass; e2e notation.spec.ts and preferences.spec.ts 16/16; CI green on this head. vitest 1552 pass / 47 fail, the 47 LFS photo failures of #67.

Out of scope: profiles and cookies, GuidedCaptureSetup.res, NetImage.res, schemas and fingerprint, wider docs.

Blocker: none.

🤖 Generated with Claude Code

@wstein
wstein force-pushed the feat/app-orbit64-v2-only branch from 12f3814 to 2e7e48a Compare November 18, 2026 10:52
@wstein
wstein changed the base branch from main to feat/app-size-range-15-profiles November 18, 2026 10:52
@wstein

wstein commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Review: FINDINGS head=12f3814980abedcd6fb1e5d40d94d86d4ec020bd patch-id=a2add69d8bb330ef671df7b997714ef8a3cc852b pr=69
blocking src/core/capture/CaptureFlow.res:132: a valid 9x9-15x15 V2 token typed or pasted into Type colors now throws "Unsupported cube size" (src/core/profiles/ProfileSettings.res:109, cubeSizes 2..7 plus imported 8) in with no error boundary; on main the same token gets an alert. Playwright on this head: 8x8 works, 9/12/15 crash. The hint (src/client/manualFaceletInput.tsx:24) invites it. Fix: stack on #67 or name "merge after #67" as a blocker and verify on the stacked head, or refuse sizes the app cannot hold yet.
blocking src/client/notationCard.tsx:49: restoring cube && size <= 7 ? in the useMemo survives all unit tests (314 pass); the tests cover orbit64TokenOf, not the card. A typed 8x8 cube shows the token today, so an e2e in e2e/notation.spec.ts (8x8 facelets -> token of 122 characters, read back) kills it.
nit src/cube/notation/Orbit64Token.res:54: dropping the entry.model == Color guard survives; picture tokens then return non-URF letters from decodeOrbit64Token (the UI still refuses them through fromURFFacelets). Add a picture-token case.
nit src/cube/notation/Orbit64Token.res:54: dropping String.trim survives (both callers trim).
nit docs/user-guide.md:170: "format V2" links to FORMAT.md (V1); FORMAT-V2.md fits.
nit test/cube/notation/notationOutput.test.ts:196: comment says the app does not run the Flix token codec; it runs a port.
nit test/orbit64Token.test.ts: codec cases live at test/ root, AGENTS.md places notation tests under test/cube/.
nit history and text: 5032a0a adds Orbit64Token without its test (test arrives in 48f7c18), so test-first is not visible; PR text names "W2" without a repo reference.
Checked: Orbit64Coords is a pure move (only odd and two unused types dropped, all 12 exports used); no V1 remnants; license notice fits. 84 V1 vectors of lengths 5/12/27/66/90 encode and decode unchanged; 43-character token gets the token error. Encode/decode at 15: about 2 ms.
Runs: npm ci, typecheck, lint, format:check, build, typos rc 0; git diff --check clean; vitest 1417/48 with one load timeout (test/syntheticFixture.test.ts, 11/11 when rerun alone), so 1418/47 vs main 1403/47, same failing files; e2e/notation.spec.ts 3/3.
Mutations: n<=7, Canonical, maxSize 14, 43 not a token, error text, V1 widths, WRG direction, format Wrg, token detection off, pattern without -_ killed; maxSize 16 equivalent.
CI on this head: CI success (test, typos). Commits: Conventional, Co-Authored-By trailer, author and committer match git config, no CRLF, no session links, no .github change.

@wstein
wstein force-pushed the feat/app-orbit64-v2-only branch from 8e0d1c0 to ef5a73a Compare November 18, 2026 11:09
@wstein

wstein commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=ef5a73afc6d65e040aa04dd469a1230b53af90a2 patch-id=7ca782456b54124abddab83f5dafb40ab832e10e pr=69
Round 2 against #67 (6e7c447). git range-diff: 12a42a9, 6fc4d6d, b95c2f8 = the round-1 commits; three new commits; no foreign commit.
Round-1 blocking 1 resolved: e2e/notation.spec.ts 8x8-15x15 pass with no pageerror (Playwright, workers 1); CubeSizeRange max 14 makes the 15x15 case fail.
Round-1 blocking 2 resolved: cube && size <= 7 in src/client/notationCard.tsx fails 8 e2e cases.
Further mutations: token from WRG facelets 9 e2e fail; Orbit64Token maxSize 14 1 e2e fail; color guard removed 1 unit fail; String.trim removed 1 unit fail.
nit e2e/notation.spec.ts:98-103: the read-back step cannot fail. Token detection off in CaptureFlow.res keeps all 11 e2e green, because the refused token leaves the same cube on screen and the alert is dismissed. Unit tests kill this mutation (parseCubeInput round trip). Show another cube before reading back, or fail on a dialog.
Round-1 nits addressed: picture-token case, test moved to test/cube/notation/, FORMAT-V2.md link, codec comment, PR text names #67.
Runs: npm ci, typecheck, lint, format:check, build, typos rc 0; git diff --check clean. vitest 1558 pass / 47 fail vs base #67 1542 / 47, same failing files (LFS photos). e2e notation and preferences 16/16.
CI on this head: CI success (test, typos). Commits: Conventional, Co-Authored-By trailer, author and committer match git config, no CRLF, no session links, no .github change. PR text 21 lines, Blocker line present.
Merge order: after #67; a new #67 head needs a rebase and a delta review.

Base automatically changed from feat/app-size-range-15-profiles to main November 18, 2026 15:04
wstein and others added 6 commits November 18, 2026 15:31
Orbit64Token.res writes and reads the V2 color framed token through the
facelet bridge. Tokens of sizes 2, 3, 4, 6 and 7 equal the V1 strings.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The notation card writes a token for every size, the typed-input reader
decodes V2 tokens, and the texts say 2×2–15×15. The UI-layer tests
round-trip token and facelets for every size.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
V2 is the only state token format. The coordinate arithmetic the V2 codec
shares moves to Orbit64Coords.res; the V1 token code, its slot tables, its
TypeScript entry points and its test are removed. The V1 reference vectors
stay as V2 input vectors.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Typed facelets show a token of the size's width, and the token read back
gives the same facelets, without page errors.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The test lives under test/cube/notation. A picture-model token is refused and
a token with surrounding spaces is read.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@wstein

wstein commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Review: CLEAR head=d5d500ff0fb098592ebe87fa583abb4deb3283ad patch-id=7ca782456b54124abddab83f5dafb40ab832e10e pr=69
Round 3 delta after the rebase onto main 9ecef3e. git range-diff against ef5a73a: all six commits =; the diff origin/main...HEAD equals the round-2 diff against #67 line for line; patch-id unchanged.
Round-1 blocking findings stay resolved: e2e/notation.spec.ts 8x8-15x15 pass with no pageerror; cube && size <= 7 in src/client/notationCard.tsx fails 8 e2e cases; CubeSizeRange maxCubeSize 14 fails the 15x15 case.
Round-2 nit stands: e2e/notation.spec.ts:98-103 cannot fail on the read-back; token detection off in CaptureFlow.res keeps 11/11 e2e green (unit tests kill it).
Extra failures: not reproduced. Full vitest with load below 18: main 1682 pass / 47 fail, this head 1698 / 47, the same failing tests (fixtures 23, liveFaceAppearance 24, gridAlignmentRealCrops suite, LFS photos). netImage 154/154, spatialChoiceFrame 5/5, syntheticFixture 11/11 at this head; the PR does not touch NetImage, and netImage passes facelet strings with spaces, which are never tokens.
test/properties/CubeProperties_test.res: same property (encode, token check, decode equals the facelets) on Orbit64Token, 12/12 pass.
Runs: npm ci, typecheck, lint, format:check, build, typos rc 0; git diff --check clean; e2e notation and preferences 16/16 on a local port.
CI on this head: CI success (test, typos). Commits: Conventional, Co-Authored-By trailer, author and committer match git config, no CRLF, no session links. PR text 19 lines with the Blocker line.

@wstein
wstein marked this pull request as ready for review November 18, 2026 16:31
@wstein
wstein added this pull request to stack #74 November 18, 2026 16:41
@wstein
wstein merged commit 11cd659 into main Nov 18, 2026
2 checks passed
@wstein
wstein deleted the feat/app-orbit64-v2-only branch November 18, 2026 16:41
wstein added a commit that referenced this pull request Nov 18, 2026
The app token is the V2 codec since #69, so the property
no longer needs the 2 to 7 generator of the removed V1 codec.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
wstein added a commit that referenced this pull request Nov 18, 2026
The app token is the V2 codec since #69, so the property
no longer needs the 2 to 7 generator of the removed V1 codec.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant